maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Tablegen] Optimize isSubsetOf() in AsmMatcherEmitter.cpp. NFC 

isSubsetOf() could be very slow if the hierarchy of the RegisterClasses
of the target is very complicated.
This is mainly caused by the fact that isSubset() is called
multiple times over the same SuperClass of a register class
if this ends up being the super class of a register class
from multiple paths.

Differential Revision: https://reviews.llvm.org/D49124

llvm-svn: 337020
This commit is contained in:
Marcello Maggioni 2018-07-13 16:36:14 +00:00
parent 9cad502555
commit 218b6a2a2a
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
llvm/utils/TableGen/AsmMatcherEmitter.cpp
View File

@ -273,9 +273,17 @@ public:
return true; return true;
// ... or if any of its super classes are a subset of RHS. // ... or if any of its super classes are a subset of RHS.
for (const ClassInfo *CI : SuperClasses) SmallVector<const ClassInfo *, 16> Worklist(SuperClasses.begin(),
if (CI->isSubsetOf(RHS)) SuperClasses.end());
SmallPtrSet<const ClassInfo *, 16> Visited;
while (!Worklist.empty()) {
auto *CI = Worklist.pop_back_val();
if (CI == &RHS)
return true; return true;
for (auto *Super : CI->SuperClasses)
if (Visited.insert(Super).second)
Worklist.push_back(Super);
}
return false; return false;
} }