Reenable "Always import constants" after compile time fixes

Summary:
Reenables importing of constants by default, which was disabled in
D73724 due to excessive thin link times. These inefficiencies were
fixed in D73851.

I re-measured thin link times for a number of binaries that had compile
time explosions with importing of constants previously and confirmed
they no longer have any notable increases with it enabled.

Reviewers: wmi, evgeny777

Subscribers: hiraditya, arphaman, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D74512
This commit is contained in:
Teresa Johnson 2020-02-12 15:17:56 -08:00
parent b6a9fe2099
commit 2102ef8aad
1 changed files with 1 additions and 3 deletions

View File

@ -31,10 +31,8 @@ static cl::opt<bool> PropagateAttrs("propagate-attrs", cl::init(true),
cl::Hidden,
cl::desc("Propagate attributes in index"));
// FIXME: Enable again when thin link compile time regressions understood and
// addressed
static cl::opt<bool> ImportConstantsWithRefs(
"import-constants-with-refs", cl::init(false), cl::Hidden,
"import-constants-with-refs", cl::init(true), cl::Hidden,
cl::desc("Import constant global variables with references"));
FunctionSummary FunctionSummary::ExternalNode =