From 20644a9540c85f1d6af601fd7ca56f758831601e Mon Sep 17 00:00:00 2001 From: JF Bastien Date: Wed, 14 Aug 2019 04:30:51 +0000 Subject: [PATCH] Remove minimum toolchain soft-error Summary: Back in January I changed the minimum toolchain version required to build clang and LLVM: D57264. Since then we've release LLVM 8, following [our process](http://llvm.org/docs/DeveloperPolicy.html#toolchain) it's therefore now a good time to remove the soft-error and officially deprecate older toolchains. I tried this out last Tursday night to see if any bots complained, and I saw no complaints. I also manually audited bots and didn't see any bot that should break, but their toolchain information is unreliable and some bots are offline. Once this patch stick we'll move to C++14 as we've [already agreed](http://lists.llvm.org/pipermail/llvm-dev/2019-January/129452.html). Subscribers: mgorny, jkorous, dexonsmith, llvm-commits, EricWF, thakis, chandlerc Tags: #llvm Differential Revision: https://reviews.llvm.org/D66188 llvm-svn: 368799 --- llvm/cmake/modules/CheckCompilerVersion.cmake | 8 ++++---- llvm/docs/GettingStarted.rst | 9 --------- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/llvm/cmake/modules/CheckCompilerVersion.cmake b/llvm/cmake/modules/CheckCompilerVersion.cmake index 2f4d75f1ebea..ad70d85dc6a7 100644 --- a/llvm/cmake/modules/CheckCompilerVersion.cmake +++ b/llvm/cmake/modules/CheckCompilerVersion.cmake @@ -4,11 +4,11 @@ include(CheckCXXSourceCompiles) -set(GCC_MIN 4.8) +set(GCC_MIN 5.1) set(GCC_SOFT_ERROR 5.1) -set(CLANG_MIN 3.1) +set(CLANG_MIN 3.5) set(CLANG_SOFT_ERROR 3.5) -set(APPLECLANG_MIN 3.1) +set(APPLECLANG_MIN 6.0) set(APPLECLANG_SOFT_ERROR 6.0) # https://en.wikipedia.org/wiki/Microsoft_Visual_C#Internal_version_numbering @@ -17,7 +17,7 @@ set(MSVC_MIN 19.1) set(MSVC_SOFT_ERROR 19.1) # Map the above GCC versions to dates: https://gcc.gnu.org/develop.html#timeline -set(GCC_MIN_DATE 20130322) +set(GCC_MIN_DATE 20150422) set(GCC_SOFT_ERROR_DATE 20150422) diff --git a/llvm/docs/GettingStarted.rst b/llvm/docs/GettingStarted.rst index 9825e848a517..a874b49b1fd9 100644 --- a/llvm/docs/GettingStarted.rst +++ b/llvm/docs/GettingStarted.rst @@ -235,15 +235,6 @@ popular host toolchains for specific minimum versions in our build systems: * GCC 5.1 * Visual Studio 2017 -The below versions currently soft-error as we transition to the new compiler -versions listed above. The LLVM codebase is currently known to compile correctly -with the following compilers, though this will change in the near future: - -* Clang 3.1 -* Apple Clang 3.1 -* GCC 4.8 -* Visual Studio 2017 - Anything older than these toolchains *may* work, but will require forcing the build system with a special option and is not really a supported host platform. Also note that older versions of these compilers have often crashed or