From 204f2e500a4fd3dd0f951e72d58013dda0cf999b Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Wed, 16 Jul 2014 23:25:44 +0000 Subject: [PATCH] DebugInfo: Ensure the ASTConsumer "HandleTagDeclRequireDefinition" callback path is tested. By having the two variables 'a' and 'b' in this test in a namespace, the type was required to be complete before any debug info was ever emitted (the entire namespace is parsed before the variables were emitted), this meant that the codepath in which a declaration is emitted, then later on the type is required to be complete and the debug info must be upgraded to a definition was not used. Moving the variables outside a namespace fixes this test coverage bug. (interestingly, code coverage didn't help here - HandleTagDeclRequireDefinition is fully covered because it's called even in cases where the type hasn't been emitted for debug info at all (further down in CGDebugInfo this no-ops) - so CC wouldn't've helped catch this test coverage problem) llvm-svn: 213211 --- clang/test/CodeGenCXX/debug-info-class-limited.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/clang/test/CodeGenCXX/debug-info-class-limited.cpp b/clang/test/CodeGenCXX/debug-info-class-limited.cpp index 8936af756f62..82b2fecfd3f7 100644 --- a/clang/test/CodeGenCXX/debug-info-class-limited.cpp +++ b/clang/test/CodeGenCXX/debug-info-class-limited.cpp @@ -1,17 +1,15 @@ // RUN: %clang_cc1 -emit-llvm -fno-standalone-debug -g -o - %s | FileCheck %s // RUN: %clang_cc1 -emit-llvm -fno-standalone-debug -g -o - -load %llvmshlibdir/PrintFunctionNames%pluginext %s 2>&1 | FileCheck %s -namespace PR16214_1 { -// CHECK-DAG: [ DW_TAG_structure_type ] [foo] [line [[@LINE+1]], {{.*}} [def] -struct foo { +// CHECK-DAG: [ DW_TAG_structure_type ] [PR16214] [line [[@LINE+1]], {{.*}} [def] +struct PR16214 { int i; }; -typedef foo bar; +typedef PR16214 bar; bar *a; bar b; -} namespace PR14467 { // CHECK-DAG: [ DW_TAG_structure_type ] [foo] [line [[@LINE+1]], {{.*}} [def]