maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Clean up comments that I missed when changing the triple representation. 

Somehow, I even missed the ones I wrote just the other day...

Thanks to Matt for the code review.

llvm-svn: 151045
This commit is contained in:
Chandler Carruth 2012-02-21 08:31:18 +00:00
parent 789456bf68
commit 1f3325a6d9
2 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/include/llvm/ADT/Triple.h
View File

@ -132,7 +132,8 @@ public:
/// @name Constructors
/// @{
/// \brief Default constructor produces an empty, invalid triple.
/// \brief Default constructor is the same as an empty string and leaves all
/// triple fields unknown.
Triple() : Data(), Arch(), Vendor(), OS(), Environment() {}
explicit Triple(const Twine &Str);

17
llvm/lib/Support/Triple.cpp
View File

@ -292,10 +292,8 @@ Triple::EnvironmentType Triple::ParseEnvironment(StringRef EnvironmentName) {
/// \brief Construct a triple from the string representation provided.
///
/// This doesn't actually parse the string representation eagerly. Instead it
/// stores it, and tracks the fact that it hasn't been parsed. The first time
/// any of the structural queries are made, the string is parsed and the
/// results cached in various members.
/// This stores the string representation and parses the various pieces into
/// enum members.
Triple::Triple(const Twine &Str)
: Data(Str.str()),
Arch(ParseArch(getArchName())),
@ -307,9 +305,9 @@ Triple::Triple(const Twine &Str)
/// \brief Construct a triple from string representations of the architecture,
/// vendor, and OS.
///
/// This doesn't actually use these already distinct strings to setup the
/// triple information. Instead it joins them into a canonical form of a triple
/// string, and lazily parses it on use.
/// This joins each argument into a canonical string representation and parses
/// them into enum members. It leaves the environment unknown and omits it from
/// the string representation.
Triple::Triple(const Twine &ArchStr, const Twine &VendorStr, const Twine &OSStr)
: Data((ArchStr + Twine('-') + VendorStr + Twine('-') + OSStr).str()),
Arch(ParseArch(ArchStr.str())),
@ -321,9 +319,8 @@ Triple::Triple(const Twine &ArchStr, const Twine &VendorStr, const Twine &OSStr)
/// \brief Construct a triple from string representations of the architecture,
/// vendor, OS, and environment.
///
/// This doesn't actually use these already distinct strings to setup the
/// triple information. Instead it joins them into a canonical form of a triple
/// string, and lazily parses it on use.
/// This joins each argument into a canonical string representation and parses
/// them into enum members.
Triple::Triple(const Twine &ArchStr, const Twine &VendorStr, const Twine &OSStr,
const Twine &EnvironmentStr)
: Data((ArchStr + Twine('-') + VendorStr + Twine('-') + OSStr + Twine('-') +