maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[flang] Fix off-by-one results from folding MAXEXPONENT and MINEXPONENT 

Every one was too low by one.

Differential Revision: https://reviews.llvm.org/D114027
This commit is contained in:
Peter Klausler 2021-11-15 15:18:32 -08:00
parent 1dc1c944d8
commit 1e954a1c66
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
flang/include/flang/Evaluate/real.h
View File

@ -150,8 +150,8 @@ public:
static constexpr int DIGITS{binaryPrecision}; static constexpr int DIGITS{binaryPrecision};
static constexpr int PRECISION{Details::decimalPrecision}; static constexpr int PRECISION{Details::decimalPrecision};
static constexpr int RANGE{Details::decimalRange}; static constexpr int RANGE{Details::decimalRange};
static constexpr int MAXEXPONENT{maxExponent - 1 - exponentBias}; static constexpr int MAXEXPONENT{maxExponent - exponentBias};
static constexpr int MINEXPONENT{1 - exponentBias}; static constexpr int MINEXPONENT{2 - exponentBias};
constexpr Real FlushSubnormalToZero() const { constexpr Real FlushSubnormalToZero() const {
if (IsSubnormal()) { if (IsSubnormal()) {

24
flang/test/Evaluate/folding07.f90
View File

@ -204,12 +204,12 @@ module m
max8 = maxexponent(0._8), & max8 = maxexponent(0._8), &
max10 = maxexponent(0._10), & max10 = maxexponent(0._10), &
max16 = maxexponent(0._16) max16 = maxexponent(0._16)
logical, parameter :: test_max2 = max2 == 15 logical, parameter :: test_max2 = max2 == 16
logical, parameter :: test_max3 = max3 == 127 logical, parameter :: test_max3 = max3 == 128
logical, parameter :: test_max4 = max4 == 127 logical, parameter :: test_max4 = max4 == 128
logical, parameter :: test_max8 = max8 == 1023 logical, parameter :: test_max8 = max8 == 1024
logical, parameter :: test_max10 = max10 == 16383 logical, parameter :: test_max10 = max10 == 16384
logical, parameter :: test_max16 = max16 == 16383 logical, parameter :: test_max16 = max16 == 16384
integer, parameter :: & integer, parameter :: &
min2 = minexponent(0._2), & min2 = minexponent(0._2), &
@ -218,12 +218,12 @@ module m
min8 = minexponent(0._8), & min8 = minexponent(0._8), &
min10 = minexponent(0._10), & min10 = minexponent(0._10), &
min16 = minexponent(0._16) min16 = minexponent(0._16)
logical, parameter :: test_min2 = min2 == -14 logical, parameter :: test_min2 = min2 == -13
logical, parameter :: test_min3 = min3 == -126 logical, parameter :: test_min3 = min3 == -125
logical, parameter :: test_min4 = min4 == -126 logical, parameter :: test_min4 = min4 == -125
logical, parameter :: test_min8 = min8 == -1022 logical, parameter :: test_min8 = min8 == -1021
logical, parameter :: test_min10 = min10 == -16382 logical, parameter :: test_min10 = min10 == -16381
logical, parameter :: test_min16 = min16 == -16382 logical, parameter :: test_min16 = min16 == -16381
integer, parameter :: & integer, parameter :: &
irange1 = range(0_1), & irange1 = range(0_1), &