maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[analyzer][NFC] Remove duplicated work from retain count leak report 

Allocation site is the key location for the leak checker.  It is a
uniqueing location for the report and a source of information for
the warning's message.

Before this patch, we calculated and used it twice in bug report and
in bug report visitor.  Such duplication is not only harmful
performance-wise (not much, but still), but also design-wise.  Because
changing something about the end piece of the report should've been
repeated for description as well.

Differential Revision: https://reviews.llvm.org/D100626
This commit is contained in:
Valeriy Savchenko 2021-04-16 11:22:25 +03:00
parent b8baa2a913
commit 1dad8c5036
1 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp
View File

@ -337,11 +337,15 @@ public:
class RefLeakReportVisitor : public RefCountReportVisitor {
public:
RefLeakReportVisitor(SymbolRef sym) : RefCountReportVisitor(sym) {}
RefLeakReportVisitor(SymbolRef Sym, const MemRegion *FirstBinding)
: RefCountReportVisitor(Sym), FirstBinding(FirstBinding) {}
PathDiagnosticPieceRef getEndPath(BugReporterContext &BRC,
const ExplodedNode *N,
PathSensitiveBugReport &BR) override;
private:
const MemRegion *FirstBinding;
};
} // end namespace retaincountchecker
@ -729,14 +733,6 @@ RefLeakReportVisitor::getEndPath(BugReporterContext &BRC,
// assigned to different variables, etc.
BR.markInteresting(Sym);
// We are reporting a leak. Walk up the graph to get to the first node where
// the symbol appeared, and also get the first VarDecl that tracked object
// is stored to.
AllocationInfo AllocI = GetAllocationSite(BRC.getStateManager(), EndN, Sym);
const MemRegion* FirstBinding = AllocI.R;
BR.markInteresting(AllocI.InterestingMethodContext);
PathDiagnosticLocation L = cast<RefLeakReport>(BR).getEndOfPath();
std::string sbuf;
@ -902,15 +898,15 @@ void RefLeakReport::createDescription(CheckerContext &Ctx) {
}
RefLeakReport::RefLeakReport(const RefCountBug &D, const LangOptions &LOpts,
ExplodedNode *n, SymbolRef sym,
ExplodedNode *N, SymbolRef Sym,
CheckerContext &Ctx)
: RefCountReport(D, LOpts, n, sym, /*isLeak=*/true) {
: RefCountReport(D, LOpts, N, Sym, /*isLeak=*/true) {
deriveAllocLocation(Ctx, sym);
deriveAllocLocation(Ctx, Sym);
if (!AllocBinding)
deriveParamLocation(Ctx, sym);
deriveParamLocation(Ctx, Sym);
createDescription(Ctx);
addVisitor(std::make_unique<RefLeakReportVisitor>(sym));
addVisitor(std::make_unique<RefLeakReportVisitor>(Sym, AllocBinding));
}