maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Revert [COFF] Statically link certain runtime library functions 

This reverts r359250 (git commit 4730604bd3)

The newly added test should use -cc1 and -emit-llvm and there are other
test failures that need fixing.

llvm-svn: 359251
This commit is contained in:
Reid Kleckner 2019-04-25 23:30:41 +00:00
parent 4730604bd3
commit 1be5369a0c
5 changed files with 8 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clang/lib/CodeGen/CodeGenModule.cpp
View File

@ -3000,13 +3000,9 @@ CodeGenModule::CreateRuntimeFunction(llvm::FunctionType *FTy, StringRef Name,
if (F->empty()) {
F->setCallingConv(getRuntimeCC());
// In Windows Itanium environments, try to mark runtime functions
// dllimport. For Mingw and MSVC, don't. We don't really know if the user
// will link their standard library statically or dynamically. Marking
// functions imported when they are not imported can cause linker errors
// and warnings.
if (!Local && getTriple().isWindowsItaniumEnvironment() &&
!getCodeGenOpts().LTOVisibilityPublicStd) {
if (!Local && getTriple().isOSBinFormatCOFF() &&
!getCodeGenOpts().LTOVisibilityPublicStd &&
!getTriple().isWindowsGNUEnvironment()) {
const FunctionDecl *FD = GetRuntimeFunctionDecl(Context, Name);
if (!FD || FD->hasAttr<DLLImportAttr>()) {
F->setDLLStorageClass(llvm::GlobalValue::DLLImportStorageClass);

20
clang/test/CodeGen/ms-symbol-linkage.cpp
View File

@ -1,20 +0,0 @@
// RUN: %clangxx -target aarch64-windows \
// RUN: -fcxx-exceptions -c -o - %s \
// RUN: | llvm-objdump -syms - 2>&1 | FileCheck %s
void foo1() { throw 1; }
// CHECK-LABEL: foo1
// CHECK-NOT: __imp__CxxThrowException
void bar();
void foo2() noexcept(true) { bar(); }
// CHECK-LABEL: foo2
// CHECK-NOT: __imp___std_terminate
struct A {};
struct B { virtual void f(); };
struct C : A, virtual B {};
struct T {};
T *foo3() { return dynamic_cast<T *>((C *)0); }
// CHECK-LABEL: foo3
// CHECK-NOT: __imp___RTDynamicCast

2
clang/test/CodeGenCXX/runtime-dllstorage.cpp
View File

@ -108,7 +108,7 @@ void l() {
// CHECK-MS-DAG: @_Init_thread_epoch = external thread_local global i32
// CHECK-MS-DAG: declare dso_local i32 @__tlregdtor(void ()*)
// CHECK-MS-DAG: declare dso_local i32 @atexit(void ()*)
// CHECK-MS-DYNAMIC-DAG: declare {{.*}} void @_CxxThrowException
// CHECK-MS-DYNAMIC-DAG: declare dllimport {{.*}} void @_CxxThrowException
// CHECK-MS-STATIC-DAG: declare {{.*}} void @_CxxThrowException
// CHECK-MS-DAG: declare dso_local noalias i8* @"??2@YAPAXI@Z"
// CHECK-MS-DAG: declare dso_local void @_Init_thread_header(i32*)

4
clang/test/CodeGenObjC/gnu-init.m
View File

@ -100,6 +100,6 @@
// Check our load function is in a comdat.
// CHECK-WIN: define linkonce_odr hidden void @.objcv2_load_function() comdat {
// Make sure we do not have dllimport on the load function
// CHECK-WIN: declare dso_local void @__objc_load
// Make sure we have dllimport on the load function
// CHECK-WIN: declare dllimport void @__objc_load

3
clang/test/CodeGenObjCXX/msabi-stret.mm
View File

@ -13,5 +13,6 @@ S f() {
return [I m:S()];
}
// CHECK: declare dso_local void @objc_msgSend_stret(i8*, i8*, ...)
// CHECK: declare dllimport void @objc_msgSend_stret(i8*, i8*, ...)
// CHECK-NOT: declare dllimport void @objc_msgSend(i8*, i8*, ...)