maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Teach -Wuninitialized about indirect goto. Fixes PR 9071. 

llvm-svn: 124394
This commit is contained in:
Ted Kremenek 2011-01-27 18:51:39 +00:00
parent 5fcfb2fe0c
commit 1be4a59a11
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clang/lib/Analysis/UninitializedValuesV2.cpp
View File

@ -158,8 +158,8 @@ static BinaryOperator *getLogicalOperatorInChain(const CFGBlock *block) {
llvm::BitVector &CFGBlockValues::getBitVector(const CFGBlock *block,
const CFGBlock *dstBlock) {
unsigned idx = block->getBlockID();
if (dstBlock && block->succ_size() == 2 && block->pred_size() == 2) {
assert(block->getTerminator());
if (dstBlock && block->succ_size() == 2 && block->pred_size() == 2 &&
block->getTerminator()) {
if (getLogicalOperatorInChain(block)) {
if (*block->succ_begin() == dstBlock)
return lazyCreate(vals[idx].first);

11
clang/test/Sema/uninit-variables.c
View File

@ -229,3 +229,14 @@ void test35(int x) {
^{ y = (x == 0); }();
}
// Test handling of indirect goto.
void test36()
{
void **pc; // expected-warning{{use of uninitialized variable 'pc'}} expected-note{{ add initialization to silence this warning}}
void *dummy[] = { &&L1, &&L2 };
L1:
goto *pc; // expected-note{{variable 'pc' is possibly uninitialized when used here}}
L2:
goto *pc;
}