maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Add `static` to a function that is used only in one file. 

llvm-svn: 276774
This commit is contained in:
Rui Ueyama 2016-07-26 17:35:42 +00:00
parent 29c567a3f0
commit 1b59f27c9a
2 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lld/ELF/Writer.cpp
View File

@ -930,7 +930,7 @@ void Writer<ELFT>::addStartStopSymbols(OutputSectionBase<ELFT> *Sec) {
Symtab.addSynthetic(Stop, Sec, DefinedSynthetic<ELFT>::SectionEnd);
}
template <class ELFT> bool elf::needsPtLoad(OutputSectionBase<ELFT> *Sec) {
template <class ELFT> static bool needsPtLoad(OutputSectionBase<ELFT> *Sec) {
if (!(Sec->getFlags() & SHF_ALLOC))
return false;
@ -982,7 +982,7 @@ std::vector<PhdrEntry<ELFT>> Writer<ELFT>::createPhdrs() {
if (Sec->getFlags() & SHF_TLS)
TlsHdr.add(Sec);
if (!needsPtLoad<ELFT>(Sec))
if (!needsPtLoad(Sec))
continue;
// If flags changed then we want new load segment.
@ -1077,7 +1077,7 @@ template <class ELFT> void Writer<ELFT>::assignAddresses() {
Alignment = std::max<uintX_t>(Alignment, Target->PageSize);
// We only assign VAs to allocated sections.
if (needsPtLoad<ELFT>(Sec)) {
if (needsPtLoad(Sec)) {
VA = alignTo(VA, Alignment);
Sec->setVA(VA);
VA += Sec->getSize();
@ -1338,11 +1338,6 @@ template bool elf::isRelroSection<ELF32BE>(OutputSectionBase<ELF32BE> *);
template bool elf::isRelroSection<ELF64LE>(OutputSectionBase<ELF64LE> *);
template bool elf::isRelroSection<ELF64BE>(OutputSectionBase<ELF64BE> *);
template bool elf::needsPtLoad<ELF32LE>(OutputSectionBase<ELF32LE> *);
template bool elf::needsPtLoad<ELF32BE>(OutputSectionBase<ELF32BE> *);
template bool elf::needsPtLoad<ELF64LE>(OutputSectionBase<ELF64LE> *);
template bool elf::needsPtLoad<ELF64BE>(OutputSectionBase<ELF64BE> *);
template StringRef elf::getOutputSectionName<ELF32LE>(InputSectionBase<ELF32LE> *);
template StringRef elf::getOutputSectionName<ELF32BE>(InputSectionBase<ELF32BE> *);
template StringRef elf::getOutputSectionName<ELF64LE>(InputSectionBase<ELF64LE> *);

1
lld/ELF/Writer.h
View File

@ -27,7 +27,6 @@ template <class ELFT> void writeResult(SymbolTable<ELFT> *Symtab);
template <class ELFT> void markLive();
template <class ELFT> bool isOutputDynamic();
template <class ELFT> bool isRelroSection(OutputSectionBase<ELFT> *Sec);
template <class ELFT> bool needsPtLoad(OutputSectionBase<ELFT> *Sec);
uint32_t toPhdrFlags(uint64_t Flags);
// This describes a program header entry.