maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Revert "Debug info: On ARM ensure that the data sections come before the" 

Cut back on the cargo cult. The order of __DATA sections doesn't affect
generated code.

This reverts commit r197922.

llvm-svn: 199680
This commit is contained in:
Adrian Prantl 2014-01-20 19:15:55 +00:00
parent b39a9b8b0c
commit 1a89924d84
2 changed files with 0 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
llvm/lib/Target/ARM/ARMAsmPrinter.cpp
View File

@ -489,19 +489,6 @@ void ARMAsmPrinter::EmitStartOfAsmFile(Module &M) {
SectionKind::getText());
OutStreamer.SwitchSection(StaticInitSect);
}
// Compiling with debug info should not affect the code
// generation! Since some of the data sections are first switched
// to only in ASMPrinter::doFinalization(), the debug info
// sections would come before the data sections in the object
// file. This is problematic, since PC-relative loads have to use
// different instruction sequences in order to reach global data
// in the same object file.
OutStreamer.SwitchSection(getObjFileLowering().getCStringSection());
OutStreamer.SwitchSection(getObjFileLowering().getDataSection());
OutStreamer.SwitchSection(getObjFileLowering().getDataCommonSection());
OutStreamer.SwitchSection(getObjFileLowering().getDataBSSSection());
OutStreamer.SwitchSection(getObjFileLowering().getNonLazySymbolPointerSection());
}
// Use unified assembler syntax.

26
llvm/test/DebugInfo/ARM/sectionorder.ll
View File

@ -1,26 +0,0 @@
; RUN: llc -filetype=asm %s -o - | FileCheck %s
; Verifies that the DWARF* sections come _after_ the data sections.
; rdar://problem/15623193
; CHECK: .section __TEXT,__text,
; CHECK-NOT: __DWARF,__debug
; CHECK: .section __TEXT,__cstring,cstring_literals
; CHECK-NOT: __DWARF,__debug
; CHECK: .section __DATA,__data
; CHECK-NOT: __DWARF,__debug
; CHECK: .section __DATA,__common
; CHECK-NOT: __DWARF,__debug
; CHECK: .section __DATA,__bss
; CHECK-NOT: __DWARF,__debug
; CHECK: .section __DATA,__nl_symbol_ptr,non_lazy_symbol_pointers
target triple = "thumbv7-apple-ios"
!llvm.module.flags = !{!3, !4}
!llvm.dbg.cu = !{!0}
!0 = metadata !{i32 786449, i32 0, i32 12, metadata !"test.c", metadata !"/Volumes/Data/radar/15623193", metadata !"LLVM", i1 true, i1 false, metadata !"", i32 0, metadata !1, metadata !1, metadata !1, metadata !1} ; [ DW_TAG_compile_unit ] [/Volumes/Data/radar/15623193/test.c] [DW_LANG_C99]
!1 = metadata !{metadata !2}
!2 = metadata !{i32 0}
!3 = metadata !{i32 2, metadata !"Dwarf Version", i32 2}
!4 = metadata !{i32 1, metadata !"Debug Info Version", i32 1}