maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Handle ARM ELF symbols properly: skip $t* and $a* symbols in ObjectFileELF. 

ELF objects contain marker symbols to differentiate between ARM and
THUMB functions. Instead of storing them internally and having garbage
show up when symbols are searched for by the user, we can just skip them
and not store them at all, as we never actually need them.

Change by Stephane Sezer.

Tested:
Ubuntu 14.04 x86_64
MacOSX 10.9.4 x86_64

llvm-svn: 217782
This commit is contained in:
Todd Fiala 2014-09-15 16:27:44 +00:00
parent 36d791023e
commit 1a08866aab
1 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
View File

@ -1746,6 +1746,32 @@ ObjectFileELF::ParseSymbols (Symtab *symtab,
}
}
ArchSpec arch;
if (GetArchitecture(arch) &&
arch.GetMachine() == llvm::Triple::arm)
{
// ELF symbol tables may contain some mapping symbols. They provide
// information about the underlying data. There are three of them
// currently defined:
// $a[.<any>]* - marks an ARM instruction sequence
// $t[.<any>]* - marks a THUMB instruction sequence
// $d[.<any>]* - marks a data item sequence (e.g. lit pool)
// These symbols interfere with normal debugger operations and we
// don't need them. We can drop them here.
static const llvm::StringRef g_armelf_arm_marker("$a");
static const llvm::StringRef g_armelf_thumb_marker("$t");
static const llvm::StringRef g_armelf_data_marker("$d");
llvm::StringRef symbol_name_ref(symbol_name);
if (symbol_name &&
(symbol_name_ref.startswith(g_armelf_arm_marker) ||
symbol_name_ref.startswith(g_armelf_thumb_marker) ||
symbol_name_ref.startswith(g_armelf_data_marker)))
continue;
}
// If the symbol section we've found has no data (SHT_NOBITS), then check the module section
// list. This can happen if we're parsing the debug file and it has no .text section, for example.
if (symbol_section_sp && (symbol_section_sp->GetFileSize() == 0))