maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Make sure that reinterpret_cast gets a CastKind on all successful 

paths. Fixes "cannot compile this unexpected cast lvalue yet" error in
llvm/lib/Analysis/IPA/GlobalsModRef.cpp.

llvm-svn: 91932
This commit is contained in:
Douglas Gregor 2009-12-22 22:47:22 +00:00
parent ef3fdc1cbd
commit 19fc0b753a
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang/lib/Sema/SemaCXXCast.cpp
View File

@ -1053,8 +1053,11 @@ static TryCastResult TryReinterpretCast(Sema &Self, Expr *SrcExpr,
return TC_NotApplicable;
// If both types have the same size, we can successfully cast.
if (Self.Context.getTypeSize(SrcType) == Self.Context.getTypeSize(DestType))
if (Self.Context.getTypeSize(SrcType)
== Self.Context.getTypeSize(DestType)) {
Kind = CastExpr::CK_BitCast;
return TC_Success;
}
if (destIsScalar)
msg = diag::err_bad_cxx_cast_vector_to_scalar_different_size;
@ -1083,6 +1086,7 @@ static TryCastResult TryReinterpretCast(Sema &Self, Expr *SrcExpr,
// to the same type. However, the behavior of compilers is pretty consistent
// on this point: allow same-type conversion if the involved types are
// pointers, disallow otherwise.
Kind = CastExpr::CK_NoOp;
return TC_Success;
}

6
clang/test/CodeGenCXX/casts.cpp
View File

@ -5,6 +5,8 @@ namespace PR5248 {
struct A {
void copyFrom(const A &src);
void addRef(void);
A& operator=(int);
};
void A::copyFrom(const A &src) {
@ -12,3 +14,7 @@ void A::copyFrom(const A &src) {
}
}
// reinterpret_cast to self
void test(PR5248::A* a) {
reinterpret_cast<PR5248::A&>(*a) = 17;
}