From 194c00935263e88e3222a531ba1f3f2570b06eb3 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Mon, 30 Dec 2013 03:43:30 +0000 Subject: [PATCH] Port r198088 (set NO_DEAD_STRIP for clang) from make to cmake. Also stop setting passing -dead_strip explicitly for libclang and instead rely on this now happening by default. (And make it happen by default for add_clang_library, which doesn't use the library cmake functions from llvm.) llvm-svn: 198200 --- clang/CMakeLists.txt | 1 + clang/tools/driver/CMakeLists.txt | 3 +++ clang/tools/libclang/CMakeLists.txt | 3 +-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/clang/CMakeLists.txt b/clang/CMakeLists.txt index 18e472f3017e..c8f71029c9e5 100644 --- a/clang/CMakeLists.txt +++ b/clang/CMakeLists.txt @@ -305,6 +305,7 @@ macro(add_clang_library name) set(libkind) endif() add_library( ${name} ${libkind} ${srcs} ) + add_dead_strip( ${name} ) if( LLVM_COMMON_DEPENDS ) add_dependencies( ${name} ${LLVM_COMMON_DEPENDS} ) endif( LLVM_COMMON_DEPENDS ) diff --git a/clang/tools/driver/CMakeLists.txt b/clang/tools/driver/CMakeLists.txt index 3526006bbbc8..021c755c0148 100644 --- a/clang/tools/driver/CMakeLists.txt +++ b/clang/tools/driver/CMakeLists.txt @@ -16,6 +16,9 @@ set( LLVM_LINK_COMPONENTS Vectorize ) +# Support plugins. +set(LLVM_NO_DEAD_STRIP 1) + add_clang_executable(clang driver.cpp cc1_main.cpp diff --git a/clang/tools/libclang/CMakeLists.txt b/clang/tools/libclang/CMakeLists.txt index aa050d535639..881a86923acf 100644 --- a/clang/tools/libclang/CMakeLists.txt +++ b/clang/tools/libclang/CMakeLists.txt @@ -84,8 +84,7 @@ if( LLVM_ENABLE_PIC ) endif() if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin") - set(LIBCLANG_LINK_FLAGS - " -Wl,-compatibility_version -Wl,1 -Wl,-dead_strip") + set(LIBCLANG_LINK_FLAGS " -Wl,-compatibility_version -Wl,1") if (DEFINED ${LLVM_SUBMIT_VERSION}) set(LIBCLANG_LINK_FLAGS "${LIBCLANG_LINK_FLAGS} -Wl,-current_version -Wl,${LLVM_SUBMIT_VERSION}.${LLVM_SUBMIT_SUBVERSION}")