forked from OSchip/llvm-project
DAG: Stop dropping invariant/dereferencable
When legalizing illegal FP load results, this was for some reason dropping the invariant and dereferencable memory flags. There doesn't seem to be any reason for this, and the equivalent isn't done for integer loads. Fixes an issue in a future AMDGPU commit where some identical loads fail to merge because one of the loads ends up dropping the flags. llvm-svn: 334020
This commit is contained in:
parent
e4ff0bd401
commit
191bc71541
|
@ -2102,13 +2102,12 @@ SDValue DAGTypeLegalizer::PromoteFloatRes_LOAD(SDNode *N) {
|
|||
|
||||
// Load the value as an integer value with the same number of bits.
|
||||
EVT IVT = EVT::getIntegerVT(*DAG.getContext(), VT.getSizeInBits());
|
||||
auto MMOFlags =
|
||||
L->getMemOperand()->getFlags() &
|
||||
~(MachineMemOperand::MOInvariant | MachineMemOperand::MODereferenceable);
|
||||
SDValue newL = DAG.getLoad(L->getAddressingMode(), L->getExtensionType(), IVT,
|
||||
SDLoc(N), L->getChain(), L->getBasePtr(),
|
||||
L->getOffset(), L->getPointerInfo(), IVT,
|
||||
L->getAlignment(), MMOFlags, L->getAAInfo());
|
||||
L->getAlignment(),
|
||||
L->getMemOperand()->getFlags(),
|
||||
L->getAAInfo());
|
||||
// Legalize the chain result by replacing uses of the old value chain with the
|
||||
// new one
|
||||
ReplaceValueWith(SDValue(N, 1), newL.getValue(1));
|
||||
|
|
|
@ -0,0 +1,13 @@
|
|||
; RUN: llc -march=amdgcn -mcpu=tahiti -verify-machineinstrs -stop-after=isel -o - %s | FileCheck -check-prefix=GCN %s
|
||||
|
||||
; Type legalization for illegal FP type results was dropping invariant
|
||||
; and dereferenceable flags.
|
||||
|
||||
; GCN: BUFFER_LOAD_USHORT_OFFSET killed %{{[0-9]+}}, 0, 0, 0, 0, 0, implicit $exec :: (dereferenceable invariant load 2 from %ir.ptr, addrspace 4)
|
||||
define half @legalize_f16_load(half addrspace(4)* dereferenceable(4) %ptr) {
|
||||
%load = load half, half addrspace(4)* %ptr, !invariant.load !0
|
||||
%add = fadd half %load, 1.0
|
||||
ret half %add
|
||||
}
|
||||
|
||||
!0 = !{}
|
Loading…
Reference in New Issue