Don't ask for a mode when we are not keeping the file.

llvm-svn: 185123
This commit is contained in:
Rafael Espindola 2013-06-28 01:05:47 +00:00
parent 12ecb331af
commit 1842482359
2 changed files with 3 additions and 4 deletions

View File

@ -573,8 +573,7 @@ error_code unique_file(const Twine &model, int &result_fd,
/// @brief Simpler version for clients that don't want an open file.
error_code unique_file(const Twine &Model, SmallVectorImpl<char> &ResultPath,
bool MakeAbsolute = true,
unsigned Mode = owner_read | owner_write);
bool MakeAbsolute = true);
error_code createUniqueDirectory(const Twine &Prefix,
SmallVectorImpl<char> &ResultPath);

View File

@ -626,12 +626,12 @@ bool is_relative(const Twine &path) {
namespace fs {
error_code unique_file(const Twine &Model, SmallVectorImpl<char> &ResultPath,
bool MakeAbsolute, unsigned Mode) {
bool MakeAbsolute) {
// FIXME: This is really inefficient. unique_path creates a path an tries to
// open it. We should factor the code so that we just don't create/open the
// file when we don't need it.
int FD;
error_code Ret = unique_file(Model, FD, ResultPath, MakeAbsolute, Mode);
error_code Ret = unique_file(Model, FD, ResultPath, MakeAbsolute, all_read);
if (Ret)
return Ret;