From 179588ea3951a81feff57990e7ce7bd38181026d Mon Sep 17 00:00:00 2001 From: Ashay Rane Date: Fri, 15 Jul 2022 17:53:06 -0700 Subject: [PATCH] [mlir] remove unnecessary statements in test A previous commit (f2b94bd) added some unnecessary statements that dereferenced operations only to get the operations back. This patch removes the unnecessary statements. Reviewed By: rriddle Differential Revision: https://reviews.llvm.org/D129913 --- mlir/test/lib/IR/TestVisitorsGeneric.cpp | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/mlir/test/lib/IR/TestVisitorsGeneric.cpp b/mlir/test/lib/IR/TestVisitorsGeneric.cpp index 833d6294db52..00148df26e35 100644 --- a/mlir/test/lib/IR/TestVisitorsGeneric.cpp +++ b/mlir/test/lib/IR/TestVisitorsGeneric.cpp @@ -131,10 +131,8 @@ struct TestGenericIRBlockVisitorInterruptPass auto walker = [&](Block *block) { for (Operation &op : *block) - for (OpResult result : op.getResults()) - if (Operation *definingOp = result.getDefiningOp()) - if (definingOp->getAttrOfType("interrupt")) - return WalkResult::interrupt(); + if (op.getAttrOfType("interrupt")) + return WalkResult::interrupt(); llvm::outs() << "step " << stepNo++ << "\n"; return WalkResult::advance(); @@ -163,12 +161,9 @@ struct TestGenericIRRegionVisitorInterruptPass int stepNo = 0; auto walker = [&](Region *region) { - for (Block &block : *region) - for (Operation &op : block) - for (OpResult result : op.getResults()) - if (Operation *definingOp = result.getDefiningOp()) - if (definingOp->getAttrOfType("interrupt")) - return WalkResult::interrupt(); + for (Operation &op : region->getOps()) + if (op.getAttrOfType("interrupt")) + return WalkResult::interrupt(); llvm::outs() << "step " << stepNo++ << "\n"; return WalkResult::advance();