maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix MSVC "not all control paths return a value" warning. NFCI.

This commit is contained in:
Simon Pilgrim 2020-02-21 18:23:29 +00:00
parent 2769fb90f0
commit 1723f21993
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang/lib/ASTMatchers/GtestMatchers.cpp
View File

@ -38,6 +38,7 @@ static DeclarationMatcher getComparisonDecl(GtestCmp Cmp) {
case GtestCmp::Lt:
return functionDecl(hasName("::testing::internal::CmpHelperLT"));
}
llvm_unreachable("Unhandled GtestCmp enum");
}
static llvm::StringRef getAssertMacro(GtestCmp Cmp) {
@ -55,6 +56,7 @@ static llvm::StringRef getAssertMacro(GtestCmp Cmp) {
case GtestCmp::Lt:
return "ASSERT_LT";
}
llvm_unreachable("Unhandled GtestCmp enum");
}
static llvm::StringRef getExpectMacro(GtestCmp Cmp) {
@ -72,6 +74,7 @@ static llvm::StringRef getExpectMacro(GtestCmp Cmp) {
case GtestCmp::Lt:
return "EXPECT_LT";
}
llvm_unreachable("Unhandled GtestCmp enum");
}
// In general, AST matchers cannot match calls to macros. However, we can