forked from OSchip/llvm-project
[analyzer] Extract NilReceiverHandler
Differential Revision: https://reviews.llvm.org/D103902
This commit is contained in:
parent
85f475c979
commit
1639dcb279
|
@ -2116,6 +2116,24 @@ public:
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
class NilReceiverHandler final : public ExpressionHandler {
|
||||||
|
public:
|
||||||
|
using ExpressionHandler::ExpressionHandler;
|
||||||
|
|
||||||
|
Tracker::Result handle(const Expr *Inner, const ExplodedNode *InputNode,
|
||||||
|
const ExplodedNode *LVNode,
|
||||||
|
TrackingOptions Opts) override {
|
||||||
|
// The message send could be nil due to the receiver being nil.
|
||||||
|
// At this point in the path, the receiver should be live since we are at
|
||||||
|
// the message send expr. If it is nil, start tracking it.
|
||||||
|
if (const Expr *Receiver =
|
||||||
|
NilReceiverBRVisitor::getNilReceiver(Inner, LVNode))
|
||||||
|
return getParentTracker().track(Receiver, LVNode, Opts);
|
||||||
|
|
||||||
|
return {};
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
class DefaultExpressionHandler final : public ExpressionHandler {
|
class DefaultExpressionHandler final : public ExpressionHandler {
|
||||||
public:
|
public:
|
||||||
using ExpressionHandler::ExpressionHandler;
|
using ExpressionHandler::ExpressionHandler;
|
||||||
|
@ -2128,13 +2146,6 @@ public:
|
||||||
PathSensitiveBugReport &Report = getParentTracker().getReport();
|
PathSensitiveBugReport &Report = getParentTracker().getReport();
|
||||||
Tracker::Result Result;
|
Tracker::Result Result;
|
||||||
|
|
||||||
// The message send could be nil due to the receiver being nil.
|
|
||||||
// At this point in the path, the receiver should be live since we are at
|
|
||||||
// the message send expr. If it is nil, start tracking it.
|
|
||||||
if (const Expr *Receiver =
|
|
||||||
NilReceiverBRVisitor::getNilReceiver(Inner, LVNode))
|
|
||||||
Result.combineWith(getParentTracker().track(Receiver, LVNode, Opts));
|
|
||||||
|
|
||||||
// Track the index if this is an array subscript.
|
// Track the index if this is an array subscript.
|
||||||
if (const auto *Arr = dyn_cast<ArraySubscriptExpr>(Inner))
|
if (const auto *Arr = dyn_cast<ArraySubscriptExpr>(Inner))
|
||||||
Result.combineWith(getParentTracker().track(
|
Result.combineWith(getParentTracker().track(
|
||||||
|
@ -2308,6 +2319,7 @@ public:
|
||||||
Tracker::Tracker(PathSensitiveBugReport &Report) : Report(Report) {
|
Tracker::Tracker(PathSensitiveBugReport &Report) : Report(Report) {
|
||||||
// Default expression handlers.
|
// Default expression handlers.
|
||||||
addLowPriorityHandler<ControlDependencyHandler>();
|
addLowPriorityHandler<ControlDependencyHandler>();
|
||||||
|
addLowPriorityHandler<NilReceiverHandler>();
|
||||||
addLowPriorityHandler<DefaultExpressionHandler>();
|
addLowPriorityHandler<DefaultExpressionHandler>();
|
||||||
addLowPriorityHandler<PRValueHandler>();
|
addLowPriorityHandler<PRValueHandler>();
|
||||||
// Default store handlers.
|
// Default store handlers.
|
||||||
|
|
Loading…
Reference in New Issue