From 15f7bc78572543d75f56d1e7989801a2ac08c430 Mon Sep 17 00:00:00 2001 From: Daniel Sanders Date: Fri, 3 Apr 2020 15:50:11 -0700 Subject: [PATCH] Add option to limit Debugify to locations (omitting variables) Summary: It can be helpful to test behaviour w.r.t locations without having DEBUG_VALUE around. In particular, because DEBUG_VALUE has the potential to change CodeGen behaviour (e.g. hasOneUse() vs hasOneNonDbgUse()) while locations generally don't. Reviewers: aprantl, bogner Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D77438 --- llvm/lib/Transforms/Utils/Debugify.cpp | 14 +++++++++++++ .../test/Transforms/Util/Debugify/loc-only.ll | 21 +++++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 llvm/test/Transforms/Util/Debugify/loc-only.ll diff --git a/llvm/lib/Transforms/Utils/Debugify.cpp b/llvm/lib/Transforms/Utils/Debugify.cpp index b1274d948e88..a9cdf652b271 100644 --- a/llvm/lib/Transforms/Utils/Debugify.cpp +++ b/llvm/lib/Transforms/Utils/Debugify.cpp @@ -30,6 +30,17 @@ namespace { cl::opt Quiet("debugify-quiet", cl::desc("Suppress verbose debugify output")); +enum class Level { + Locations, + LocationsAndVariables +}; +cl::opt DebugifyLevel( + "debugify-level", cl::desc("Kind of debug info to add"), + cl::values(clEnumValN(Level::Locations, "locations", "Locations only"), + clEnumValN(Level::LocationsAndVariables, "location+variables", + "Locations and Variables")), + cl::init(Level::LocationsAndVariables)); + raw_ostream &dbg() { return Quiet ? nulls() : errs(); } uint64_t getAllocSizeInBits(Module &M, Type *Ty) { @@ -100,6 +111,9 @@ bool applyDebugifyMetadata(Module &M, for (Instruction &I : BB) I.setDebugLoc(DILocation::get(Ctx, NextLine++, 1, SP)); + if (DebugifyLevel < Level::LocationsAndVariables) + continue; + // Inserting debug values into EH pads can break IR invariants. if (BB.isEHPad()) continue; diff --git a/llvm/test/Transforms/Util/Debugify/loc-only.ll b/llvm/test/Transforms/Util/Debugify/loc-only.ll new file mode 100644 index 000000000000..250e72d28eb9 --- /dev/null +++ b/llvm/test/Transforms/Util/Debugify/loc-only.ll @@ -0,0 +1,21 @@ +; RUN: opt -debugify -S < %s | FileCheck --check-prefixes=ALL,VALUE %s +; RUN: opt -debugify -debugify-level=locations -S < %s | FileCheck --check-prefixes=ALL --implicit-check-not=dbg.value %s + +; ALL-LABEL: @test +define void @test() { + %add = add i32 1, 2 +; ALL-NEXT: %add = add i32 1, 2, !dbg [[L1:![0-9]+]] +; VALUE-NEXT: call void @llvm.dbg.value(metadata i32 %add, metadata [[add:![0-9]+]], metadata !DIExpression()), !dbg [[L1]] + %sub = sub i32 %add, 1 +; ALL-NEXT: %sub = sub i32 %add, 1, !dbg [[L2:![0-9]+]] +; VALUE-NEXT: call void @llvm.dbg.value(metadata i32 %sub, metadata [[sub:![0-9]+]], metadata !DIExpression()), !dbg [[L2]] +; ALL-NEXT: ret void, !dbg [[L3:![0-9]+]] + ret void +} + +; VALUE: [[add]] = !DILocalVariable +; VALUE: [[sub]] = !DILocalVariable + +; ALL: [[L1]] = !DILocation(line: 1, column: 1, scope: +; ALL: [[L2]] = !DILocation(line: 2, column: 1, scope: +; ALL: [[L3]] = !DILocation(line: 3, column: 1, scope: