maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[BOLT] Disable -lite when split function is present 

In lite mode, BOLT only transforms a subset of functions, leave the
remaining functions intact.

For NoPIC, it is fine. BOLT can scan relocations and fix-up all refs
that point to any function body in the subset.

For no-split function PIC, it is fine. Since jump tables are intra-
procedural transfer, BOLT can find both the jump table base and the
target within same function. Thus, BOLT can update and/or move jump
tables.

However, it is wrong to process a subset of functions in split function
PIC. This is because BOLT does not know if functions in the subset are
isolated, i.e., cannot be accessed by functions out of the subset,
especially via split jump table.

For example, BOLT only process three functions A, B and C. Suppose that
A is reached via jump table from A.cold, which is not processed. When
A is moved (due to optimization), the jump table in A.cold is invalid.
We cannot fix-up this jump table since it is only recognized in A.cold,
which BOLT does not process.

Solution: Disable lite mode if split function is present.

Future improvement: In lite mode, if split function is found, BOLT
processes both functions in the subset and all of their sibling
fragments.

Test Plan:
```
ninja check-bolt
```

Reviewed By: Amir, maksfb

Differential Revision: https://reviews.llvm.org/D131283
This commit is contained in:
Huan Nguyen 2022-09-28 19:25:52 +02:00 committed by Amir Ayupov
parent 12357e88af
commit 153eeb4a5e
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
bolt/lib/Rewrite/RewriteInstance.cpp
View File

@ -1429,10 +1429,17 @@ void RewriteInstance::adjustFunctionBoundaries() {
Function.hasRestoredNameRegex(".*\\.cold(\\.[0-9]+)?");
if (FragName) {
static bool PrintedWarning = false;
if (BC->HasRelocations && !PrintedWarning) {
errs() << "BOLT-WARNING: split function detected on input : "
<< *FragName << ". The support is limited in relocation mode.\n";
if (!PrintedWarning) {
PrintedWarning = true;
errs() << "BOLT-WARNING: split function detected on input : "
<< *FragName;
if (BC->HasRelocations)
errs() << ". The support is limited in relocation mode";
if (opts::Lite) {
opts::Lite = false;
errs() << "\nBOLT-WARNING: disabling lite mode (-lite) when split "
<< "functions are present\n";
}
}
Function.IsFragment = true;
}