maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[LLDB] Remove undefined behavior in TestConstStaticIntegralMember.py 

Setting an enum without a fixed underlying type to a value which is outside the
value range is undefined behavior.

The initializer needs to be a constant expression and therefore this was always
ill-formed we just were not diagnosing it before.

See D130058 and D131307 for more details.

Differential Revision: https://reviews.llvm.org/D131460
This commit is contained in:
Shafik Yaghmour 2022-08-08 19:23:53 -07:00
parent 03e345b519
commit 1438639a2f
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py
View File

@ -53,8 +53,6 @@ class TestCase(TestBase):
# Test an unscoped enum.
self.expect_expr("A::enum_val", result_value="enum_case2")
# Test an unscoped enum with an invalid enum case.
self.expect_expr("A::invalid_enum_val", result_value="enum_case1 | enum_case2 | 0x4")
# Test a scoped enum.
self.expect_expr("A::scoped_enum_val", result_value="scoped_enum_case2")

2
lldb/test/API/lang/cpp/const_static_integral_member/main.cpp
View File

@ -47,7 +47,6 @@ struct A {
std::numeric_limits<unsigned long long>::min();
const static Enum enum_val = enum_case2;
const static Enum invalid_enum_val = static_cast<Enum>(enum_case2 + 5);
const static ScopedEnum scoped_enum_val = ScopedEnum::scoped_enum_case2;
const static ScopedEnum invalid_scoped_enum_val = static_cast<ScopedEnum>(5);
const static ScopedCharEnum scoped_char_enum_val = ScopedCharEnum::case2;
@ -102,7 +101,6 @@ int main() {
int member_copy = ClassWithOnlyConstStatic::member;
Enum e = A::enum_val;
e = A::invalid_enum_val;
ScopedEnum se = A::scoped_enum_val;
se = A::invalid_scoped_enum_val;
ScopedCharEnum sce = A::scoped_char_enum_val;