From 13d7e0d012c6e5ab6728bbfb57d52b6bb2ff8ad2 Mon Sep 17 00:00:00 2001 From: Jakob Stoklund Olesen Date: Fri, 29 Oct 2010 00:40:59 +0000 Subject: [PATCH] Fix broken equivalence class calculation. We could probably also use EquvivalenceClasses.h except it looks like overkill when elements are continuous integers. llvm-svn: 117631 --- llvm/lib/CodeGen/LiveInterval.cpp | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/llvm/lib/CodeGen/LiveInterval.cpp b/llvm/lib/CodeGen/LiveInterval.cpp index 6fb60362be6f..27a572c0ea75 100644 --- a/llvm/lib/CodeGen/LiveInterval.cpp +++ b/llvm/lib/CodeGen/LiveInterval.cpp @@ -709,15 +709,14 @@ void LiveRange::print(raw_ostream &os) const { /// multiple LiveIntervals. void ConnectedVNInfoEqClasses::Connect(unsigned a, unsigned b) { - unsigned eqa = eqClass_[a]; - unsigned eqb = eqClass_[b]; - if (eqa == eqb) - return; - // Make sure a and b are in the same class while maintaining eqClass_[i] <= i. - if (eqa > eqb) - eqClass_[a] = eqb; - else - eqClass_[b] = eqa; + while (eqClass_[a] != eqClass_[b]) { + if (eqClass_[a] > eqClass_[b]) + std::swap(a, b); + unsigned t = eqClass_[b]; + assert(t <= b && "Invariant broken"); + eqClass_[b] = eqClass_[a]; + b = t; + } } unsigned ConnectedVNInfoEqClasses::Renumber() { @@ -745,8 +744,6 @@ unsigned ConnectedVNInfoEqClasses::Classify(const LiveInterval *LI) { for (LiveInterval::const_vni_iterator I = LI->vni_begin(), E = LI->vni_end(); I != E; ++I) { const VNInfo *VNI = *I; - if (VNI->id == eqClass_.size()) - eqClass_.push_back(VNI->id); assert(!VNI->isUnused() && "Cannot handle unused values"); if (VNI->isPHIDef()) { const MachineBasicBlock *MBB = lis_.getMBBFromIndex(VNI->def);