maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[IRTranslator] Refactor to expose a translateBinaryOp method. 

This method will be used for every binary operation.

NFC.

llvm-svn: 272431
This commit is contained in:
Quentin Colombet 2016-06-10 20:50:18 +00:00
parent d1f6c840ee
commit 13c55e07ed
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
llvm/include/llvm/CodeGen/GlobalISel/IRTranslator.h
View File

@ -87,12 +87,20 @@ private:
// Note: we would need to do something so that we can recognize such operand
// as constants.
// 3. Create the generic instruction.
bool translateADD(const Instruction &Inst);
bool translateBr(const Instruction &Inst);
bool translateReturn(const Instruction &Inst);
/// Translate \p Inst into a binary operation \p Opcode.
/// Insert the newly translated instruction right where the MIRBuilder
/// is set.
///
/// \pre \p Inst is a binary operation.
///
/// \return true if the translation succeeded.
bool translateBinaryOp(unsigned Opcode, const Instruction &Inst);
// Builder for machine instruction a la IRBuilder.
// I.e., compared to regular MIBuilder, this one also inserts the instruction
// in the current block, it can creates block, etc., basically a kind of

6
llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
View File

@ -61,7 +61,7 @@ MachineBasicBlock &IRTranslator::getOrCreateBB(const BasicBlock &BB) {
return *MBB;
}
bool IRTranslator::translateADD(const Instruction &Inst) {
bool IRTranslator::translateBinaryOp(unsigned Opcode, const Instruction &Inst) {
// Get or create a virtual register for each value.
// Unless the value is a Constant => loadimm cst?
// or inline constant each time?
@ -69,7 +69,7 @@ bool IRTranslator::translateADD(const Instruction &Inst) {
unsigned Op0 = getOrCreateVReg(*Inst.getOperand(0));
unsigned Op1 = getOrCreateVReg(*Inst.getOperand(1));
unsigned Res = getOrCreateVReg(Inst);
MIRBuilder.buildInstr(TargetOpcode::G_ADD, Inst.getType(), Res, Op0, Op1);
MIRBuilder.buildInstr(Opcode, Inst.getType(), Res, Op0, Op1);
return true;
}
@ -103,7 +103,7 @@ bool IRTranslator::translate(const Instruction &Inst) {
MIRBuilder.setDebugLoc(Inst.getDebugLoc());
switch(Inst.getOpcode()) {
case Instruction::Add:
return translateADD(Inst);
return translateBinaryOp(TargetOpcode::G_ADD, Inst);
case Instruction::Br:
return translateBr(Inst);
case Instruction::Ret: