From 13ba23bb79ce689f29d67e8656a599f019e9bb03 Mon Sep 17 00:00:00 2001
From: Justin Bogner <mail@justinbogner.com>
Date: Fri, 19 Sep 2014 08:13:16 +0000
Subject: [PATCH] llvm-cov: Fix dropped lines when filters were applied

Uncovered lines in the middle of a covered region weren't being shown
when filtering to a particular function.

llvm-svn: 218109
---
 .../Inputs/lineExecutionCounts.covmapping       | Bin 194 -> 162 bytes
 .../tools/llvm-cov/showLineExecutionCounts.cpp  |   7 ++++++-
 llvm/tools/llvm-cov/SourceCoverageView.cpp      |   3 ++-
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/llvm/test/tools/llvm-cov/Inputs/lineExecutionCounts.covmapping b/llvm/test/tools/llvm-cov/Inputs/lineExecutionCounts.covmapping
index 5cfa1694da2567aa1568df3db4c3a63fed0b0519..9774b89ede8c3f9010797390894a80bd112f27e0 100644
GIT binary patch
delta 85
zcmX@axQNjsC#NhoIlnBoB(=CCC9x!t<-oy)27%nf%sfU01_mV{wgX}iIH17501{&X
bVvv}xvj&g^iYe%q<Q7cK&}3wrILQD2+kO)a

delta 140
zcmZ3)c!;q+C#NhoIlnBoB(=CCC9x!tWyZmV27%nf%sfU01_mb}wgX}in4!SH01{&X
zVvv}xvj&g^iaF?q7N-^!>nG-<R_KGw(+3%*Uy`4nQw-+o0xi%l&d4wK$;?Z2tw>ES
WEy>K!bIvc#E14KC#K=6c$N&Iu*C<y2

diff --git a/llvm/test/tools/llvm-cov/showLineExecutionCounts.cpp b/llvm/test/tools/llvm-cov/showLineExecutionCounts.cpp
index 9c94344e5ee2..34baa574dab2 100644
--- a/llvm/test/tools/llvm-cov/showLineExecutionCounts.cpp
+++ b/llvm/test/tools/llvm-cov/showLineExecutionCounts.cpp
@@ -1,5 +1,8 @@
-// RUN: llvm-cov show %S/Inputs/lineExecutionCounts.covmapping -instr-profile %S/Inputs/lineExecutionCounts.profdata -no-colors -filename-equivalence %s | FileCheck %s
+// RUN: llvm-cov show %S/Inputs/lineExecutionCounts.covmapping -instr-profile %S/Inputs/lineExecutionCounts.profdata -no-colors -filename-equivalence %s | FileCheck -check-prefix=CHECK -check-prefix=WHOLE-FILE %s
+// RUN: llvm-cov show %S/Inputs/lineExecutionCounts.covmapping -instr-profile %S/Inputs/lineExecutionCounts.profdata -no-colors -filename-equivalence -name=main %s | FileCheck -check-prefix=CHECK -check-prefix=FILTER %s
 
+// before any coverage              // WHOLE-FILE:    | [[@LINE]]|// before
+                                    // FILTER-NOT:    | [[@LINE-1]]|// before
 int main() {                             // CHECK:   1| [[@LINE]]|int main(
   int x = 0;                             // CHECK:   1| [[@LINE]]|  int x
                                          // CHECK:   1| [[@LINE]]|
@@ -20,6 +23,8 @@ int main() {                             // CHECK:   1| [[@LINE]]|int main(
                                          // CHECK:   1| [[@LINE]]|
   return 0;                              // CHECK:   1| [[@LINE]]|  return
 }                                        // CHECK:   1| [[@LINE]]|}
+// after coverage                   // WHOLE-FILE:    | [[@LINE]]|// after
+                                    // FILTER-NOT:    | [[@LINE-1]]|// after
 
 // llvm-cov doesn't work on big endian yet
 // XFAIL: powerpc64-, s390x, mips-, mips64-, sparc
diff --git a/llvm/tools/llvm-cov/SourceCoverageView.cpp b/llvm/tools/llvm-cov/SourceCoverageView.cpp
index 2ad3e145198c..3be54f828da7 100644
--- a/llvm/tools/llvm-cov/SourceCoverageView.cpp
+++ b/llvm/tools/llvm-cov/SourceCoverageView.cpp
@@ -163,6 +163,7 @@ void SourceCoverageView::render(raw_ostream &OS, bool WholeFile,
   auto NextSegment = CoverageSegments.begin();
   auto EndSegment = CoverageSegments.end();
 
+  unsigned FirstLine = NextSegment != EndSegment ? NextSegment->Line : 0;
   const CoverageSegment *WrappedSegment = nullptr;
   SmallVector<const CoverageSegment *, 8> LineSegments;
   for (line_iterator LI(File, /*SkipBlanks=*/false); !LI.is_at_eof(); ++LI) {
@@ -171,7 +172,7 @@ void SourceCoverageView::render(raw_ostream &OS, bool WholeFile,
     if (!WholeFile) {
       if (NextSegment == EndSegment)
         break;
-      else if (LI.line_number() < NextSegment->Line)
+      else if (LI.line_number() < FirstLine)
         continue;
     }