maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Debug Info: update comments and add a FIXME. 

llvm-svn: 187157
This commit is contained in:
Manman Ren 2013-07-25 21:19:31 +00:00
parent 9260ed6c06
commit 13b63e8983
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/lib/IR/DebugInfo.cpp
View File

@ -406,9 +406,12 @@ bool DIObjCProperty::Verify() const {
return DbgNode->getNumOperands() == 8; return DbgNode->getNumOperands() == 8;
} }
/// We allow an empty string to represent null. But we don't allow /// Check if a field at position Elt of a MDNode is a MDNode.
/// a non-empty string in a MDNode field. /// We currently allow an empty string and an integer.
/// But we don't allow a non-empty string in a MDNode field.
static bool fieldIsMDNode(const MDNode *DbgNode, unsigned Elt) { static bool fieldIsMDNode(const MDNode *DbgNode, unsigned Elt) {
// FIXME: This function should return true, if the field is null or the field
// is indeed a MDNode: return !Fld || isa<MDNode>(Fld).
Value *Fld = getField(DbgNode, Elt); Value *Fld = getField(DbgNode, Elt);
if (Fld && isa<MDString>(Fld) && if (Fld && isa<MDString>(Fld) &&
!cast<MDString>(Fld)->getString().empty()) !cast<MDString>(Fld)->getString().empty())