maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] RenamerClangTidy now correctly renames `using namespace` decls 

Summary: Fixes [[ https://bugs.llvm.org/show_bug.cgi?id=45039 | readability-identifier-naming doesn't rename using namespace correctly. ]]

Reviewers: aaron.ballman, gribozavr2, JonasToth, hokein, alexfh

Reviewed By: aaron.ballman

Subscribers: xazax.hun, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D75220
This commit is contained in:
Nathan James 2020-03-18 22:13:01 +00:00
parent 5ffb30fd6c
commit 1365ab4b63
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp
View File

@ -272,6 +272,11 @@ void RenamerClangTidyCheck::check(const MatchFinder::MatchResult &Result) {
}
if (const auto *Decl = Result.Nodes.getNodeAs<NamedDecl>("decl")) {
// Fix using namespace declarations.
if (const auto *UsingNS = dyn_cast<UsingDirectiveDecl>(Decl))
addUsage(NamingCheckFailures, UsingNS->getNominatedNamespaceAsWritten(),
UsingNS->getIdentLocation());
if (!Decl->getIdentifier() || Decl->getName().empty() || Decl->isImplicit())
return;

5
clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming.cpp
View File

@ -527,3 +527,8 @@ void MyPoiterFunction(int * p_normal_pointer, int * const constant_ptr){
// CHECK-FIXES: {{^}} int * const lc_PointerB = nullptr;{{$}}
}
using namespace FOO_NS;
// CHECK-FIXES: {{^}}using namespace foo_ns;
using namespace FOO_NS::InlineNamespace;
// CHECK-FIXES: {{^}}using namespace foo_ns::inline_namespace;