maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[BOLT] Ignore __builtin_unreachable destination 

Summary:
For functions with unknown control flow, do not populate TakenBranches
with an entry pointing to the end of the function.

(cherry picked from FBD18034019)
This commit is contained in:
Maksim Panchenko 2019-10-20 20:46:32 -07:00
parent b807641e2a
commit 12aca4005c
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bolt/src/BinaryFunction.cpp
View File

@ -1465,6 +1465,9 @@ void BinaryFunction::postProcessJumpTables() {
if (opts::StrictMode && hasInternalReference()) {
for (auto Offset : UnknownIndirectBranchOffsets) {
for (auto PossibleDestination : ExternallyReferencedOffsets) {
// Ignore __builtin_unreachable().
if (PossibleDestination == getSize())
continue;
TakenBranches.emplace_back(Offset, PossibleDestination);
}
}
@ -1825,8 +1828,11 @@ bool BinaryFunction::buildCFG(MCPlusBuilder::AllocatorIdTy AllocatorId) {
if (!FromBB || !ToBB) {
if (!FromBB)
errs() << "BOLT-ERROR: cannot find BB containing the branch.\n";
if (!ToBB)
if (!ToBB) {
dbgs() << "registering branch [0x" << Twine::utohexstr(Branch.first)
<< "] -> [0x" << Twine::utohexstr(Branch.second) << "]\n";
errs() << "BOLT-ERROR: cannot find BB containing branch destination.\n";
}
BC.exitWithBugReport("disassembly failed - inconsistent branch found.",
*this);
}