maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[DWARFYAML] Fix unintialized value Is64BitAddrSize. NFC. 

This patch fixes the undefined behavior that reported by ubsan.

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/44524/
This commit is contained in:
Xing GUO 2020-08-05 00:09:12 +08:00
parent 0de547ed4a
commit 12605bfd1f
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/include/llvm/ObjectYAML/DWARFEmitter.h
View File

@ -48,7 +48,8 @@ std::function<Error(raw_ostream &, const Data &)>
getDWARFEmitterByName(StringRef SecName); getDWARFEmitterByName(StringRef SecName);
Expected<StringMap<std::unique_ptr<MemoryBuffer>>> Expected<StringMap<std::unique_ptr<MemoryBuffer>>>
emitDebugSections(StringRef YAMLString, emitDebugSections(StringRef YAMLString,
bool IsLittleEndian = sys::IsLittleEndianHost); bool IsLittleEndian = sys::IsLittleEndianHost,
bool Is64BitAddrSize = true);
} // end namespace DWARFYAML } // end namespace DWARFYAML
} // end namespace llvm } // end namespace llvm

5
llvm/lib/ObjectYAML/DWARFEmitter.cpp
View File

@ -945,7 +945,8 @@ emitDebugSectionImpl(const DWARFYAML::Data &DI, StringRef Sec,
} }
Expected<StringMap<std::unique_ptr<MemoryBuffer>>> Expected<StringMap<std::unique_ptr<MemoryBuffer>>>
DWARFYAML::emitDebugSections(StringRef YAMLString, bool IsLittleEndian) { DWARFYAML::emitDebugSections(StringRef YAMLString, bool IsLittleEndian,
bool Is64BitAddrSize) {
auto CollectDiagnostic = [](const SMDiagnostic &Diag, void *DiagContext) { auto CollectDiagnostic = [](const SMDiagnostic &Diag, void *DiagContext) {
*static_cast<SMDiagnostic *>(DiagContext) = Diag; *static_cast<SMDiagnostic *>(DiagContext) = Diag;
}; };
@ -956,6 +957,8 @@ DWARFYAML::emitDebugSections(StringRef YAMLString, bool IsLittleEndian) {
DWARFYAML::Data DI; DWARFYAML::Data DI;
DI.IsLittleEndian = IsLittleEndian; DI.IsLittleEndian = IsLittleEndian;
DI.Is64BitAddrSize = Is64BitAddrSize;
YIn >> DI; YIn >> DI;
if (YIn.error()) if (YIn.error())
return createStringError(YIn.error(), GeneratedDiag.getMessage()); return createStringError(YIn.error(), GeneratedDiag.getMessage());

3
llvm/unittests/DebugInfo/DWARF/DWARFDieTest.cpp
View File

@ -65,7 +65,8 @@ TEST(DWARFDie, getLocations) {
)"; )";
Expected<StringMap<std::unique_ptr<MemoryBuffer>>> Sections = Expected<StringMap<std::unique_ptr<MemoryBuffer>>> Sections =
DWARFYAML::emitDebugSections(StringRef(yamldata), DWARFYAML::emitDebugSections(StringRef(yamldata),
/*IsLittleEndian=*/true); /*IsLittleEndian=*/true,
/*Is64BitAddrSize=*/false);
ASSERT_THAT_EXPECTED(Sections, Succeeded()); ASSERT_THAT_EXPECTED(Sections, Succeeded());
std::unique_ptr<DWARFContext> Ctx = std::unique_ptr<DWARFContext> Ctx =
DWARFContext::create(*Sections, 4, /*isLittleEndian=*/true); DWARFContext::create(*Sections, 4, /*isLittleEndian=*/true);