maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

The variable "Value" is carefully set to Layout.getSymbolAddress, 

but then not actually used - maybe a bug?  Remove the variable.

llvm-svn: 107137
This commit is contained in:
Duncan Sands 2010-06-29 13:26:33 +00:00
parent 5667a08468
commit 1245e4c07d
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/MC/MachObjectWriter.cpp
View File

@ -823,7 +823,6 @@ public:
// See <reloc.h>. // See <reloc.h>.
uint32_t FixupOffset = Layout.getFragmentOffset(Fragment)+Fixup.getOffset(); uint32_t FixupOffset = Layout.getFragmentOffset(Fragment)+Fixup.getOffset();
uint32_t Value = 0;
unsigned Index = 0; unsigned Index = 0;
unsigned IsExtern = 0; unsigned IsExtern = 0;
unsigned Type = 0; unsigned Type = 0;
@ -834,7 +833,6 @@ public:
// FIXME: Currently, these are never generated (see code below). I cannot // FIXME: Currently, these are never generated (see code below). I cannot
// find a case where they are actually emitted. // find a case where they are actually emitted.
Type = RIT_Vanilla; Type = RIT_Vanilla;
Value = 0;
} else { } else {
// Check whether we need an external or internal relocation. // Check whether we need an external or internal relocation.
if (doesSymbolRequireExternRelocation(SD)) { if (doesSymbolRequireExternRelocation(SD)) {
@ -845,11 +843,9 @@ public:
// undefined. This occurs with weak definitions, for example. // undefined. This occurs with weak definitions, for example.
if (!SD->Symbol->isUndefined()) if (!SD->Symbol->isUndefined())
FixedValue -= Layout.getSymbolAddress(SD); FixedValue -= Layout.getSymbolAddress(SD);
Value = 0;
} else { } else {
// The index is the section ordinal (1-based). // The index is the section ordinal (1-based).
Index = SD->getFragment()->getParent()->getOrdinal() + 1; Index = SD->getFragment()->getParent()->getOrdinal() + 1;
Value = Layout.getSymbolAddress(SD);
} }
Type = RIT_Vanilla; Type = RIT_Vanilla;