forked from OSchip/llvm-project
Change Error unittest to use the LLVM_ENABLE_ABI_BREAKING_CHECKS instead of NDEBUG
This is consistent with the header (after r288087) and fixes the test for the configuration: -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ABI_BREAKING_CHECKS=FORCE_OFF llvm-svn: 288196
This commit is contained in:
parent
5a0a2e648c
commit
11407ae581
|
@ -102,7 +102,7 @@ TEST(Error, CheckedSuccess) {
|
|||
}
|
||||
|
||||
// Test that unchecked succes values cause an abort.
|
||||
#ifndef NDEBUG
|
||||
#ifndef LLVM_ENABLE_ABI_BREAKING_CHECKS
|
||||
TEST(Error, UncheckedSuccess) {
|
||||
EXPECT_DEATH({ Error E = Error::success(); },
|
||||
"Program aborted due to an unhandled Error:")
|
||||
|
@ -128,7 +128,7 @@ TEST(Error, ErrorAsOutParameterChecked) {
|
|||
}
|
||||
|
||||
// Test that ErrorAsOutParameter clears the checked flag on destruction.
|
||||
#ifndef NDEBUG
|
||||
#ifndef LLVM_ENABLE_ABI_BREAKING_CHECKS
|
||||
TEST(Error, ErrorAsOutParameterUnchecked) {
|
||||
EXPECT_DEATH({ Error E = Error::success(); errAsOutParamHelper(E); },
|
||||
"Program aborted due to an unhandled Error:")
|
||||
|
@ -139,7 +139,7 @@ TEST(Error, ErrorAsOutParameterUnchecked) {
|
|||
// Check that we abort on unhandled failure cases. (Force conversion to bool
|
||||
// to make sure that we don't accidentally treat checked errors as handled).
|
||||
// Test runs in debug mode only.
|
||||
#ifndef NDEBUG
|
||||
#ifndef LLVM_ENABLE_ABI_BREAKING_CHECKS
|
||||
TEST(Error, UncheckedError) {
|
||||
auto DropUnhandledError = []() {
|
||||
Error E = make_error<CustomError>(42);
|
||||
|
@ -377,7 +377,7 @@ TEST(Error, ConsumeError) {
|
|||
|
||||
// Test that handleAllUnhandledErrors crashes if an error is not caught.
|
||||
// Test runs in debug mode only.
|
||||
#ifndef NDEBUG
|
||||
#ifndef LLVM_ENABLE_ABI_BREAKING_CHECKS
|
||||
TEST(Error, FailureToHandle) {
|
||||
auto FailToHandle = []() {
|
||||
handleAllErrors(make_error<CustomError>(7), [&](const CustomSubError &SE) {
|
||||
|
@ -395,7 +395,7 @@ TEST(Error, FailureToHandle) {
|
|||
// Test that handleAllUnhandledErrors crashes if an error is returned from a
|
||||
// handler.
|
||||
// Test runs in debug mode only.
|
||||
#ifndef NDEBUG
|
||||
#ifndef LLVM_ENABLE_ABI_BREAKING_CHECKS
|
||||
TEST(Error, FailureFromHandler) {
|
||||
auto ReturnErrorFromHandler = []() {
|
||||
handleAllErrors(make_error<CustomError>(7),
|
||||
|
@ -490,7 +490,7 @@ TEST(Error, ExpectedWithReferenceType) {
|
|||
// Test Unchecked Expected<T> in success mode.
|
||||
// We expect this to blow up the same way Error would.
|
||||
// Test runs in debug mode only.
|
||||
#ifndef NDEBUG
|
||||
#ifndef LLVM_ENABLE_ABI_BREAKING_CHECKS
|
||||
TEST(Error, UncheckedExpectedInSuccessModeDestruction) {
|
||||
EXPECT_DEATH({ Expected<int> A = 7; },
|
||||
"Expected<T> must be checked before access or destruction.")
|
||||
|
@ -501,7 +501,7 @@ TEST(Error, UncheckedExpectedInSuccessModeDestruction) {
|
|||
// Test Unchecked Expected<T> in success mode.
|
||||
// We expect this to blow up the same way Error would.
|
||||
// Test runs in debug mode only.
|
||||
#ifndef NDEBUG
|
||||
#ifndef LLVM_ENABLE_ABI_BREAKING_CHECKS
|
||||
TEST(Error, UncheckedExpectedInSuccessModeAccess) {
|
||||
EXPECT_DEATH({ Expected<int> A = 7; *A; },
|
||||
"Expected<T> must be checked before access or destruction.")
|
||||
|
@ -512,7 +512,7 @@ TEST(Error, UncheckedExpectedInSuccessModeAccess) {
|
|||
// Test Unchecked Expected<T> in success mode.
|
||||
// We expect this to blow up the same way Error would.
|
||||
// Test runs in debug mode only.
|
||||
#ifndef NDEBUG
|
||||
#ifndef LLVM_ENABLE_ABI_BREAKING_CHECKS
|
||||
TEST(Error, UncheckedExpectedInSuccessModeAssignment) {
|
||||
EXPECT_DEATH({ Expected<int> A = 7; A = 7; },
|
||||
"Expected<T> must be checked before access or destruction.")
|
||||
|
@ -532,7 +532,7 @@ TEST(Error, ExpectedInFailureMode) {
|
|||
// Check that an Expected instance with an error value doesn't allow access to
|
||||
// operator*.
|
||||
// Test runs in debug mode only.
|
||||
#ifndef NDEBUG
|
||||
#ifndef LLVM_ENABLE_ABI_BREAKING_CHECKS
|
||||
TEST(Error, AccessExpectedInFailureMode) {
|
||||
Expected<int> A = make_error<CustomError>(42);
|
||||
EXPECT_DEATH(*A, "Expected<T> must be checked before access or destruction.")
|
||||
|
@ -544,7 +544,7 @@ TEST(Error, AccessExpectedInFailureMode) {
|
|||
// Check that an Expected instance with an error triggers an abort if
|
||||
// unhandled.
|
||||
// Test runs in debug mode only.
|
||||
#ifndef NDEBUG
|
||||
#ifndef LLVM_ENABLE_ABI_BREAKING_CHECKS
|
||||
TEST(Error, UnhandledExpectedInFailureMode) {
|
||||
EXPECT_DEATH({ Expected<int> A = make_error<CustomError>(42); },
|
||||
"Expected<T> must be checked before access or destruction.")
|
||||
|
|
Loading…
Reference in New Issue