maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Support] [NFC] change comment about retries in createUniqueEntity 

Rewording as requested on D50126 after the change was pushed.

llvm-svn: 338755
This commit is contained in:
Bob Haarman 2018-08-02 18:27:21 +00:00
parent e3d81572c1
commit 112ebb687a
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/lib/Support/Path.cpp
View File

@ -190,8 +190,10 @@ createUniqueEntity(const Twine &Model, int &ResultFD,
ResultPath.push_back(0);
ResultPath.pop_back();
// Limit the number of attempts we make, so that we don't infinite loop when
// we run out of filenames that fit the model.
// Limit the number of attempts we make, so that we don't infinite loop. E.g.
// "permission denied" could be for a specific file (so we retry with a
// different name) or for the whole directory (retry would always fail).
// Checking which is racy, so we try a number of times, then give up.
std::error_code EC;
for (int Retries = 128; Retries > 0; --Retries) {
// Replace '%' with random chars.