diff --git a/clang/lib/CodeGen/TargetInfo.cpp b/clang/lib/CodeGen/TargetInfo.cpp index 01fd8e7d79a6..c9f0d757946b 100644 --- a/clang/lib/CodeGen/TargetInfo.cpp +++ b/clang/lib/CodeGen/TargetInfo.cpp @@ -3340,13 +3340,13 @@ ABIArgInfo ARMABIInfo::classifyArgumentType(QualType Ty, int *VFPRegs, ABIArgInfo::getExtend() : ABIArgInfo::getDirect()); } + if (CGCXXABI::RecordArgABI RAA = getRecordArgABI(Ty, CGT)) + return ABIArgInfo::getIndirect(0, RAA == CGCXXABI::RAA_DirectInMemory); + // Ignore empty records. if (isEmptyRecord(getContext(), Ty, true)) return ABIArgInfo::getIgnore(); - if (CGCXXABI::RecordArgABI RAA = getRecordArgABI(Ty, CGT)) - return ABIArgInfo::getIndirect(0, RAA == CGCXXABI::RAA_DirectInMemory); - if (getABIKind() == ARMABIInfo::AAPCS_VFP) { // Homogeneous Aggregates need to be expanded when we can fit the aggregate // into VFP registers. diff --git a/clang/test/CodeGenCXX/empty-nontrivially-copyable.cpp b/clang/test/CodeGenCXX/empty-nontrivially-copyable.cpp new file mode 100644 index 000000000000..9ee3281505ec --- /dev/null +++ b/clang/test/CodeGenCXX/empty-nontrivially-copyable.cpp @@ -0,0 +1,25 @@ +// RUN: %clang_cc1 -triple armv7-apple-ios -x c++ -emit-llvm -o - %s | FileCheck %s + +// According to the Itanium ABI (3.1.1), types with non-trivial copy +// constructors passed by value should be passed indirectly, with the caller +// creating a temporary. + +struct Empty; + +struct Empty { + Empty(const Empty &e); + bool check(); +}; + +bool foo(Empty e) { +// CHECK: @_Z3foo5Empty(%struct.Empty* %e) +// CHECK: call {{.*}} @_ZN5Empty5checkEv(%struct.Empty* %e) + return e.check(); +} + +void caller(Empty &e) { +// CHECK: @_Z6callerR5Empty(%struct.Empty* %e) +// CHECK: call {{.*}} @_ZN5EmptyC1ERKS_(%struct.Empty* [[NEWTMP:%.*]], %struct.Empty* +// CHECK: call {{.*}} @_Z3foo5Empty(%struct.Empty* [[NEWTMP]]) + foo(e); +}