maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[libcxx] [test] Fix size_t-to-int truncation warnings in syserr.hash. 

After r289363, these tests were triggering MSVC x64 warning C4267
"conversion from 'size_t' to 'int', possible loss of data" by taking 0, 2, and 10
as std::size_t, then constructing error_code(int, const error_category&) or
error_condition(int, const error_category&) from that (N4618 19.5.3.2
[syserr.errcode.constructors]/3, 19.5.4.2 [syserr.errcondition.constructors]/3).

The fix is simple: take these ints as int, pass them to the int-taking
constructor, and perform a value-preserving static_cast<std::size_t>
when comparing them to `std::size_t result`.

Fixes D27691.

llvm-svn: 289512
This commit is contained in:
Stephan T. Lavavej 2016-12-13 01:54:58 +00:00
parent c7772add11
commit 105a3061f7
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libcxx/test/std/diagnostics/syserr/syserr.hash/error_code.pass.cpp
View File

@ -23,7 +23,7 @@
#include "test_macros.h"
void
test(std::size_t i)
test(int i)
{
typedef std::error_code T;
typedef std::hash<T> H;
@ -32,7 +32,7 @@ test(std::size_t i)
H h;
T ec(i, std::system_category());
const std::size_t result = h(ec);
LIBCPP_ASSERT(result == i);
LIBCPP_ASSERT(result == static_cast<std::size_t>(i));
((void)result); // Prevent unused warning
}

4
libcxx/test/std/diagnostics/syserr/syserr.hash/error_condition.pass.cpp
View File

@ -23,7 +23,7 @@
#include "test_macros.h"
void
test(std::size_t i)
test(int i)
{
typedef std::error_condition T;
typedef std::hash<T> H;
@ -32,7 +32,7 @@ test(std::size_t i)
H h;
T ec(i, std::system_category());
const std::size_t result = h(ec);
LIBCPP_ASSERT(result == i);
LIBCPP_ASSERT(result == static_cast<std::size_t>(i));
((void)result); // Prevent unused warning
}