maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Also convert SUBREG_TO_REG to a KILL when relevant, like the other subreg 

instructions.

This does not affect codegen much because SUBREG_TO_REG is only used by X86 and
X86 does not use the register scavenger, but it prevents verifier errors.

llvm-svn: 106583
This commit is contained in:
Jakob Stoklund Olesen 2010-06-22 22:11:07 +00:00
parent c5d712232d
commit 1023f6bd98
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
llvm/lib/CodeGen/LowerSubregs.cpp
View File

@ -169,7 +169,7 @@ bool LowerSubregsInstructionPass::LowerSubregToReg(MachineInstr *MI) {
unsigned DstReg = MI->getOperand(0).getReg(); unsigned DstReg = MI->getOperand(0).getReg();
unsigned InsReg = MI->getOperand(2).getReg(); unsigned InsReg = MI->getOperand(2).getReg();
unsigned InsSIdx = MI->getOperand(2).getSubReg(); assert(!MI->getOperand(2).getSubReg() && "SubIdx on physreg?");
unsigned SubIdx = MI->getOperand(3).getImm(); unsigned SubIdx = MI->getOperand(3).getImm();
assert(SubIdx != 0 && "Invalid index for insert_subreg"); assert(SubIdx != 0 && "Invalid index for insert_subreg");
@ -182,13 +182,18 @@ bool LowerSubregsInstructionPass::LowerSubregToReg(MachineInstr *MI) {
DEBUG(dbgs() << "subreg: CONVERTING: " << *MI); DEBUG(dbgs() << "subreg: CONVERTING: " << *MI);
if (DstSubReg == InsReg && InsSIdx == 0) { if (DstSubReg == InsReg) {
// No need to insert an identify copy instruction. // No need to insert an identify copy instruction.
// Watch out for case like this: // Watch out for case like this:
// %RAX<def> = ... // %RAX<def> = SUBREG_TO_REG 0, %EAX<kill>, 3
// %RAX<def> = SUBREG_TO_REG 0, %EAX:3<kill>, 3 // We must leave %RAX live.
// The first def is defining RAX, not EAX so the top bits were not if (DstReg != InsReg) {
// zero extended. MI->setDesc(TII->get(TargetOpcode::KILL));
MI->RemoveOperand(3); // SubIdx
MI->RemoveOperand(1); // Imm
DEBUG(dbgs() << "subreg: replace by: " << *MI);
return true;
}
DEBUG(dbgs() << "subreg: eliminated!"); DEBUG(dbgs() << "subreg: eliminated!");
} else { } else {
// Insert sub-register copy // Insert sub-register copy