maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] Add early exit for defaulted FunctionDecls 

This prevents matching of defaulted comparison operators.

Resolves: https://github.com/llvm/llvm-project/issues/53355

Author: Febbe (Fabian Keßler)
This commit is contained in:
Kirill Bobyrev 2022-02-10 20:09:46 +01:00
parent fb9646ed78
commit 100ec80ab5
2 changed files with 54 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp
View File

@ -404,14 +404,17 @@ void UseTrailingReturnTypeCheck::check(const MatchFinder::MatchResult &Result) {
const auto *Fr = Result.Nodes.getNodeAs<FriendDecl>("Friend");
assert(F && "Matcher is expected to find only FunctionDecls");
if (F->getLocation().isInvalid())
// Three-way comparison operator<=> is syntactic sugar and generates implicit
// nodes for all other operators.
if (F->getLocation().isInvalid() || F->isImplicit())
return;
// Skip functions which return just 'auto'.
// Skip functions which return 'auto' and defaulted operators.
const auto *AT = F->getDeclaredReturnType()->getAs<AutoType>();
if (AT != nullptr && !AT->isConstrained() &&
AT->getKeyword() == AutoTypeKeyword::Auto &&
!hasAnyNestedLocalQualifiers(F->getDeclaredReturnType()))
if (AT != nullptr &&
((!AT->isConstrained() && AT->getKeyword() == AutoTypeKeyword::Auto &&
!hasAnyNestedLocalQualifiers(F->getDeclaredReturnType())) ||
F->isDefaulted()))
return;
// TODO: implement those

46
clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type-cxx20.cpp
View File

@ -52,3 +52,49 @@ template <typename T>
T req2(T t) requires requires { t + t; };
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
// CHECK-FIXES: {{^}}auto req2(T t) -> T requires requires { t + t; };{{$}}
//
// Operator c++20 defaulted comparison operators
//
// Requires <compare>
namespace std {
struct strong_ordering {
using value_type = signed char;
static strong_ordering const less;
static strong_ordering const equal;
static strong_ordering const equivalent;
static strong_ordering const greater;
constexpr strong_ordering(value_type v) : val(v) {}
template <typename T>
requires(T{0}) friend constexpr auto
operator==(strong_ordering v, T u) noexcept -> bool {
return v.val == u;
}
friend constexpr auto operator==(strong_ordering v, strong_ordering w) noexcept -> bool = default;
value_type val{};
};
inline constexpr strong_ordering strong_ordering::less{-1};
inline constexpr strong_ordering strong_ordering::equal{0};
inline constexpr strong_ordering strong_ordering::equivalent{0};
inline constexpr strong_ordering strong_ordering::greater{1};
} // namespace std
struct TestDefaultOperatorA {
int a{};
int b{};
friend auto operator<=>(const TestDefaultOperatorA &, const TestDefaultOperatorA &) noexcept = default;
};
struct TestDefaultOperatorB {
int a{};
int b{};
friend auto operator==(const TestDefaultOperatorB &, const TestDefaultOperatorB &) noexcept -> bool = default;
friend bool operator<(const TestDefaultOperatorB &, const TestDefaultOperatorB &) noexcept = default;
// CHECK-MESSAGES: :[[@LINE-1]]:15: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
// CHECK-FIXES: {{^}} friend auto operator<(const TestDefaultOperatorB &, const TestDefaultOperatorB &) noexcept -> bool = default;{{$}}
};