maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[asan] Reduce flakiness in stack-overflow detection 

IsStackOverflow only treats accesses within 512 bytes of SP as stack-overflow. This should really be the size of a page instead.

The scariness_score_test.cc triggers stack overflow with frames that are even larger than a page, which can also trigger a fault that will not be recognized as stack-overflow. Let's just use smaller frames.

llvm-svn: 329980
This commit is contained in:
Kuba Mracek 2018-04-13 00:29:24 +00:00
parent 8fc5b84349
commit 0fb14e944c
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cc
View File

@ -230,7 +230,9 @@ bool SignalContext::IsStackOverflow() const {
// take it into account.
bool IsStackAccess = addr >= (sp & ~0xFFF) && addr < sp + 0xFFFF;
#else
bool IsStackAccess = addr + 512 > sp && addr < sp + 0xFFFF;
// Let's accept up to a page size away from top of stack. Things like stack
// probing can trigger accesses with such large offsets.
bool IsStackAccess = addr + GetPageSizeCached() > sp && addr < sp + 0xFFFF;
#endif
#if __powerpc__

2
compiler-rt/test/asan/TestCases/scariness_score_test.cc
View File

@ -115,7 +115,7 @@ void DoubleFree() {
}
void StackOverflow(int Idx) {
int some_stack[10000];
int some_stack[256];
static volatile int *x;
x = &some_stack[0];
if (Idx > 0)