From 0f0aee213fa684e8ae70c870afa476e8eefb54fc Mon Sep 17 00:00:00 2001 From: Evan Cheng Date: Thu, 24 Jul 2008 08:17:07 +0000 Subject: [PATCH] Fix a catastrophic PPC64 ABI bug: i32 operands which are passed in memory (all of the parameter registers are used) are loaded from sp offsets that were off by 4. llvm-svn: 53979 --- llvm/lib/Target/PowerPC/PPCISelLowering.cpp | 1 + llvm/test/CodeGen/PowerPC/2008-07-24-PPC64-CCBug.ll | 11 +++++++++++ 2 files changed, 12 insertions(+) create mode 100644 llvm/test/CodeGen/PowerPC/2008-07-24-PPC64-CCBug.ll diff --git a/llvm/lib/Target/PowerPC/PPCISelLowering.cpp b/llvm/lib/Target/PowerPC/PPCISelLowering.cpp index 2ea48cf89dbf..6bf147a6ad9f 100644 --- a/llvm/lib/Target/PowerPC/PPCISelLowering.cpp +++ b/llvm/lib/Target/PowerPC/PPCISelLowering.cpp @@ -1582,6 +1582,7 @@ PPCTargetLowering::LowerFORMAL_ARGUMENTS(SDOperand Op, ++GPR_idx; } else { needsLoad = true; + ArgSize = PtrByteSize; } // All int arguments reserve stack space in Macho ABI. if (isMachoABI || needsLoad) ArgOffset += 8; diff --git a/llvm/test/CodeGen/PowerPC/2008-07-24-PPC64-CCBug.ll b/llvm/test/CodeGen/PowerPC/2008-07-24-PPC64-CCBug.ll new file mode 100644 index 000000000000..2ccca25e2a27 --- /dev/null +++ b/llvm/test/CodeGen/PowerPC/2008-07-24-PPC64-CCBug.ll @@ -0,0 +1,11 @@ +; RUN: llvm-as < %s | llc -mtriple=powerpc64-apple-darwin | grep lwz | grep 228 + +@"\01LC" = internal constant [4 x i8] c"%d\0A\00" ; <[4 x i8]*> [#uses=1] + +define void @llvm_static_func(i32 %a0, i32 %a1, i32 %a2, i32 %a3, i32 %a4, i32 %a5, i32 %a6, i32 %a7, i32 %a8, i32 %a9, i32 %a10, i32 %a11, i32 %a12, i32 %a13, i32 %a14, i32 %a15) nounwind { +entry: + tail call i32 (i8*, ...)* @printf( i8* getelementptr ([4 x i8]* @"\01LC", i32 0, i64 0), i32 %a8 ) nounwind ; :0 [#uses=0] + ret void +} + +declare i32 @printf(i8*, ...) nounwind