maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

implement i-c-e correct evaluation for sizeof/alignof, remove some obsolete fixme's. 

llvm-svn: 40012
This commit is contained in:
Chris Lattner 2007-07-18 18:38:36 +00:00
parent 647fb22611
commit 0f0019c36e
2 changed files with 22 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
clang/AST/Expr.cpp
View File

@ -324,32 +324,36 @@ bool Expr::isIntegerConstantExpr(llvm::APSInt &Result, ASTContext &Ctx,
if (Loc) *Loc = Exp->getOperatorLoc();
return false;
case UnaryOperator::Extension:
return true;
return true; // FIXME: this is wrong.
case UnaryOperator::SizeOf:
case UnaryOperator::AlignOf:
// sizeof(vla) is not a constantexpr: C99 6.5.3.4p2.
if (!Exp->getSubExpr()->getType()->isConstantSizeType(Ctx, Loc))
return false;
// FIXME: Evaluate sizeof/alignof.
Result.zextOrTrunc(32); // FIXME: NOT RIGHT IN GENERAL.
Result = 1; // FIXME: Obviously bogus
// Return the result in the right width.
Result.zextOrTrunc(Ctx.getTypeSize(getType(), Exp->getOperatorLoc()));
// Get information about the size or align.
if (Exp->getOpcode() == UnaryOperator::SizeOf)
Result = Ctx.getTypeSize(Exp->getSubExpr()->getType(),
Exp->getOperatorLoc());
else
Result = Ctx.getTypeAlign(Exp->getSubExpr()->getType(),
Exp->getOperatorLoc());
break;
case UnaryOperator::LNot: {
bool Val = Result != 0;
Result.zextOrTrunc(32); // FIXME: NOT RIGHT IN GENERAL.
Result.zextOrTrunc(Ctx.getTypeSize(getType(), Exp->getOperatorLoc()));
Result = Val;
break;
}
case UnaryOperator::Plus:
// FIXME: Do usual unary promotions here!
break;
case UnaryOperator::Minus:
// FIXME: Do usual unary promotions here!
Result = -Result;
break;
case UnaryOperator::Not:
// FIXME: Do usual unary promotions here!
Result = ~Result;
break;
}
@ -361,9 +365,14 @@ bool Expr::isIntegerConstantExpr(llvm::APSInt &Result, ASTContext &Ctx,
if (Exp->isSizeOf() && !Exp->getArgumentType()->isConstantSizeType(Ctx,Loc))
return false;
// FIXME: Evaluate sizeof/alignof.
Result.zextOrTrunc(32); // FIXME: NOT RIGHT IN GENERAL.
Result = 1; // FIXME: Obviously bogus
// Return the result in the right width.
Result.zextOrTrunc(Ctx.getTypeSize(getType(), Exp->getOperatorLoc()));
// Get information about the size or align.
if (Exp->isSizeOf())
Result = Ctx.getTypeSize(Exp->getArgumentType(), Exp->getOperatorLoc());
else
Result = Ctx.getTypeAlign(Exp->getArgumentType(), Exp->getOperatorLoc());
break;
}
case BinaryOperatorClass: {
@ -394,7 +403,6 @@ bool Expr::isIntegerConstantExpr(llvm::APSInt &Result, ASTContext &Ctx,
return false;
}
// FIXME: These should all do the standard promotions, etc.
switch (Exp->getOpcode()) {
default:
if (Loc) *Loc = getLocStart();
@ -525,7 +533,6 @@ bool Expr::isIntegerConstantExpr(llvm::APSInt &Result, ASTContext &Ctx,
// Evalute the true one, capture the result.
if (!TrueExp->isIntegerConstantExpr(Result, Ctx, Loc, isEvaluated))
return false;
// FIXME: promotions on result.
break;
}
}

2
clang/include/clang/AST/Expr.h
View File

@ -317,6 +317,8 @@ public:
bool isSizeOf() const { return isSizeof; }
QualType getArgumentType() const { return Ty; }
SourceLocation getOperatorLoc() const { return OpLoc; }
SourceRange getSourceRange() const { return SourceRange(OpLoc, RParenLoc); }
virtual void visit(StmtVisitor &Visitor);