From 0eca0571f86ae7cea43a08985d7dcaa27effdbb2 Mon Sep 17 00:00:00 2001 From: Duncan Sands Date: Wed, 3 Sep 2008 15:31:24 +0000 Subject: [PATCH] Since onlyReadsMemory returns true if in fact doesNotAccessMemory, check doesNotAccessMemory first, since otherwise functions may be marked readonly rather than readnone. llvm-svn: 55697 --- llvm/lib/Analysis/IPA/GlobalsModRef.cpp | 6 ++++-- llvm/test/Analysis/GlobalsModRef/2008-09-03-ReadNone.ll | 9 +++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 llvm/test/Analysis/GlobalsModRef/2008-09-03-ReadNone.ll diff --git a/llvm/lib/Analysis/IPA/GlobalsModRef.cpp b/llvm/lib/Analysis/IPA/GlobalsModRef.cpp index c8347c23fdb9..5f3846949842 100644 --- a/llvm/lib/Analysis/IPA/GlobalsModRef.cpp +++ b/llvm/lib/Analysis/IPA/GlobalsModRef.cpp @@ -376,14 +376,16 @@ void GlobalsModRef::AnalyzeCallGraph(CallGraph &CG, Module &M) { if (F->isDeclaration()) { // Try to get mod/ref behaviour from function attributes. - if (F->onlyReadsMemory()) { + if (F->doesNotAccessMemory()) { + // Can't do better than that! + } else if (F->onlyReadsMemory()) { FunctionEffect |= Ref; // This function might call back into the module and read a global, so // mark all globals read somewhere as being read by this function. for (std::set::iterator GI = ReadGlobals.begin(), E = ReadGlobals.end(); GI != E; ++GI) FR.GlobalInfo[*GI] |= Ref; - } else if (!F->doesNotAccessMemory()) { + } else { // Can't say anything useful. KnowNothing = true; } diff --git a/llvm/test/Analysis/GlobalsModRef/2008-09-03-ReadNone.ll b/llvm/test/Analysis/GlobalsModRef/2008-09-03-ReadNone.ll new file mode 100644 index 000000000000..b286ada83900 --- /dev/null +++ b/llvm/test/Analysis/GlobalsModRef/2008-09-03-ReadNone.ll @@ -0,0 +1,9 @@ +; RUN: llvm-as < %s | opt -globalsmodref-aa -markmodref | llvm-dis | grep readnone | count 2 + +define i32 @f() { +entry: + %tmp = call i32 @e( ) ; [#uses=1] + ret i32 %tmp +} + +declare i32 @e() readnone