maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[PartialInliner] Partial inliner needs to check use kind before transformation 

Differential Revision: https://reviews.llvm.org/D32373

llvm-svn: 301042
This commit is contained in:
Xinliang David Li 2017-04-21 21:20:56 +00:00
parent 04593000d8
commit 0e9f6df169
2 changed files with 75 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
llvm/lib/Transforms/IPO/PartialInlining.cpp
View File

@ -85,6 +85,25 @@ Function *PartialInlinerImpl::unswitchFunction(Function *F) {
if (ReturnCount != 1)
return nullptr;
auto canAllUsesBeReplaced = [](Function *F) {
std::vector<User *> Users(F->user_begin(), F->user_end());
for (User *User : Users) {
Function *Callee = nullptr;
if (CallInst *CI = dyn_cast<CallInst>(User))
Callee = CallSite(CI).getCalledFunction();
else if (InvokeInst *II = dyn_cast<InvokeInst>(User))
Callee = CallSite(II).getCalledFunction();
if (Callee != F)
return false;
}
return true;
};
if (!canAllUsesBeReplaced(F))
return nullptr;
// Clone the function, so that we can hack away on it.
ValueToValueMapTy VMap;
Function *DuplicateFunction = CloneFunction(F, VMap);

56
llvm/test/Transforms/CodeExtractor/PartialInlineCallRef.ll Normal file
View File

@ -0,0 +1,56 @@
; RUN: opt < %s -partial-inliner -S | FileCheck %s
; RUN: opt < %s -passes=partial-inliner -S | FileCheck %s
; Function Attrs: nounwind
declare void @foo(...) local_unnamed_addr #0
; Function Attrs: noinline
define i32 @caller(i32 (i32)* nocapture %arg, i32 (i32)* nocapture %arg1, i32 %arg2) local_unnamed_addr #1 {
bb:
%tmp = tail call i32 %arg(i32 %arg2) #0
%tmp3 = tail call i32 %arg1(i32 %arg2) #0
%tmp4 = add nsw i32 %tmp3, %tmp
ret i32 %tmp4
}
; Function Attrs: nounwind
define i32 @bar(i32 %arg) #0 {
bb:
%tmp = icmp slt i32 %arg, 0
br i1 %tmp, label %bb1, label %bb2
bb1: ; preds = %bb
tail call void (...) @foo() #0
tail call void (...) @foo() #0
tail call void (...) @foo() #0
tail call void (...) @foo() #0
tail call void (...) @foo() #0
tail call void (...) @foo() #0
tail call void (...) @foo() #0
tail call void (...) @foo() #0
tail call void (...) @foo() #0
br label %bb2
bb2: ; preds = %bb1, %bb
%tmp3 = phi i32 [ 0, %bb1 ], [ 1, %bb ]
ret i32 %tmp3
}
; Function Attrs: nounwind
define i32 @dummy_caller(i32 %arg) local_unnamed_addr #0 {
bb:
; CHECK-LABEL: @dummy_caller
; check that caller is not wrongly inlined by partial inliner
; CHECK: call i32 @caller
; CHECK-NOT: call .* @bar
%tmp = tail call i32 @caller(i32 (i32)* nonnull @bar, i32 (i32)* nonnull @bar, i32 %arg)
ret i32 %tmp
}
attributes #0 = { nounwind }
attributes #1 = { noinline }
!llvm.ident = !{!0}
!0 = !{!"clang version 5.0.0 (trunk 300897) (llvm/trunk 300947)"}