maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix an assertion failure in legalizing bitcast operators on targets where 

vectors are split down to single elements as part of legalization.

llvm-svn: 37785
This commit is contained in:
Dan Gohman 2007-06-29 00:09:08 +00:00
parent 3bd318e298
commit 0de7694de6
2 changed files with 28 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
View File

@ -5568,38 +5568,30 @@ void SelectionDAGLegalize::SplitVectorOp(SDOperand Op, SDOperand &Lo,
case ISD::BIT_CONVERT: { case ISD::BIT_CONVERT: {
// We know the result is a vector. The input may be either a vector or a // We know the result is a vector. The input may be either a vector or a
// scalar value. // scalar value.
if (!MVT::isVector(Op.getOperand(0).getValueType())) { SDOperand InOp = Node->getOperand(0);
// Lower to a store/load. FIXME: this could be improved probably. if (!MVT::isVector(InOp.getValueType()) ||
SDOperand Ptr = CreateStackTemporary(Op.getOperand(0).getValueType()); MVT::getVectorNumElements(InOp.getValueType()) == 1) {
// The input is a scalar or single-element vector.
// Lower to a store/load so that it can be split.
// FIXME: this could be improved probably.
SDOperand Ptr = CreateStackTemporary(InOp.getValueType());
SDOperand St = DAG.getStore(DAG.getEntryNode(), SDOperand St = DAG.getStore(DAG.getEntryNode(),
Op.getOperand(0), Ptr, NULL, 0); InOp, Ptr, NULL, 0);
St = DAG.getLoad(NewVT, St, Ptr, NULL, 0); InOp = DAG.getLoad(Op.getValueType(), St, Ptr, NULL, 0);
SplitVectorOp(St, Lo, Hi);
} else {
// If the input is a vector type, we have to either scalarize it, pack it
// or convert it based on whether the input vector type is legal.
SDNode *InVal = Node->getOperand(0).Val;
unsigned NumElems = MVT::getVectorNumElements(InVal->getValueType(0));
assert(NumElems > 1);
{
// Split the input vector.
SplitVectorOp(Op.getOperand(0), Lo, Hi);
// Convert each of the pieces now.
Lo = DAG.getNode(ISD::BIT_CONVERT, NewVT, Lo);
Hi = DAG.getNode(ISD::BIT_CONVERT, NewVT, Hi);
}
break;
} }
// Split the vector and convert each of the pieces now.
SplitVectorOp(InOp, Lo, Hi);
Lo = DAG.getNode(ISD::BIT_CONVERT, NewVT, Lo);
Hi = DAG.getNode(ISD::BIT_CONVERT, NewVT, Hi);
break;
} }
} }
// Remember in a map if the values will be reused later. // Remember in a map if the values will be reused later.
bool isNew = bool isNew =
SplitNodes.insert(std::make_pair(Op, std::make_pair(Lo, Hi))).second; SplitNodes.insert(std::make_pair(Op, std::make_pair(Lo, Hi))).second;
assert(isNew && "Value already expanded?!?"); assert(isNew && "Value already split?!?");
} }

13
llvm/test/CodeGen/ARM/illegal-vector-bitcast.ll Normal file
View File

@ -0,0 +1,13 @@
; RUN: llvm-as < %s | llc -march=arm
define void @foo(<8 x float>* %f, <8 x float>* %g, <4 x i64>* %y)
{
%h = load <8 x float>* %f
%i = mul <8 x float> %h, <float 1.1, float 3.3, float 4.4, float 5.4, float 0.5, float 0.6, float 0.7, float 0.8>
%m = bitcast <8 x float> %i to <4 x i64>
%z = load <4 x i64>* %y
%n = mul <4 x i64> %z, %m
%p = bitcast <4 x i64> %n to <8 x float>
store <8 x float> %p, <8 x float>* %g
ret void
}