maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lldb][asan] Mark destructor as virtual to allow subclasses. 

`lldb_private::ScriptInterpreterPython::CommandDataPython` inherits from `lldb_private::BreakpointOptions::CommandData`, but the latter does not have a virtual destructor. This leads to a new-delete-type-mismatch error when running certain tests (such as `functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py`) under asan.
This commit is contained in:
Jordan Rupprecht 2020-08-20 09:15:37 -07:00
parent 87bf0b0ee9
commit 0de3d0c612
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/include/lldb/Breakpoint/BreakpointOptions.h
View File

@ -51,7 +51,7 @@ public:
: user_source(user_source), script_source(), interpreter(interp),
stop_on_error(true) {}
~CommandData() = default;
virtual ~CommandData() = default;
static const char *GetSerializationKey() { return "BKPTCMDData"; }