maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Default parameters are evil and should not be used. Case and point this checkin that fixes implicit conversions that were happening. 

llvm-svn: 185217
This commit is contained in:
Greg Clayton 2013-06-28 21:08:47 +00:00
parent b13e64eb60
commit 0d5510458e
2 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lldb/source/Expression/ClangASTSource.cpp
View File

@ -1741,18 +1741,21 @@ NameSearchContext::AddFunDecl (void *type)
m_function_types.insert(type);
const bool isInlineSpecified = false;
const bool hasWrittenPrototype = true;
const bool isConstexprSpecified = false;
clang::FunctionDecl *func_decl = FunctionDecl::Create (*m_ast_source.m_ast_context,
const_cast<DeclContext*>(m_decl_context),
SourceLocation(),
SourceLocation(),
m_decl_name.getAsIdentifierInfo(),
QualType::getFromOpaquePtr(type),
NULL,
SC_Static,
SC_Static,
false,
true);
isInlineSpecified,
hasWrittenPrototype,
isConstexprSpecified);
// We have to do more than just synthesize the FunctionDecl. We have to
// synthesize ParmVarDecls for all of the FunctionDecl's arguments. To do
// this, we raid the function's FunctionProtoType for types.

14
lldb/source/Symbol/ClangASTContext.cpp
View File

@ -5534,6 +5534,10 @@ ClangASTContext::CreateFunctionDeclaration (DeclContext *decl_ctx, const char *n
if (decl_ctx == NULL)
decl_ctx = ast->getTranslationUnitDecl();
const bool hasWrittenPrototype = true;
const bool isConstexprSpecified = false;
if (name && name[0])
{
func_decl = FunctionDecl::Create (*ast,
@ -5544,8 +5548,9 @@ ClangASTContext::CreateFunctionDeclaration (DeclContext *decl_ctx, const char *n
QualType::getFromOpaquePtr(function_clang_type),
NULL,
(FunctionDecl::StorageClass)storage,
(FunctionDecl::StorageClass)storage,
is_inline);
is_inline,
hasWrittenPrototype,
isConstexprSpecified);
}
else
{
@ -5557,8 +5562,9 @@ ClangASTContext::CreateFunctionDeclaration (DeclContext *decl_ctx, const char *n
QualType::getFromOpaquePtr(function_clang_type),
NULL,
(FunctionDecl::StorageClass)storage,
(FunctionDecl::StorageClass)storage,
is_inline);
is_inline,
hasWrittenPrototype,
isConstexprSpecified);
}
if (func_decl)
decl_ctx->addDecl (func_decl);