From 0d0a99cb96183027af8212d0b8545356b65be0d3 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 19 Apr 2022 16:22:37 -0700 Subject: [PATCH] [msan] Advance before destroying entry -fsanitize-memory-use-after-dtor reports this memory access. --- clang/lib/Analysis/PathDiagnostic.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clang/lib/Analysis/PathDiagnostic.cpp b/clang/lib/Analysis/PathDiagnostic.cpp index ee8185c2147c..90c462401806 100644 --- a/clang/lib/Analysis/PathDiagnostic.cpp +++ b/clang/lib/Analysis/PathDiagnostic.cpp @@ -434,8 +434,8 @@ void PathDiagnosticConsumer::FlushDiagnostics( } PathDiagnosticConsumer::FilesMade::~FilesMade() { - for (PDFileEntry &Entry : Set) - Entry.~PDFileEntry(); + for (auto It = Set.begin(); It != Set.end();) + (It++)->~PDFileEntry(); } void PathDiagnosticConsumer::FilesMade::addDiagnostic(const PathDiagnostic &PD,