Revert "Fix a crash in option parsing."

This fails on the bots around 1/10 of the time.

llvm-svn: 363999

lldb/lit/Driver/Inputs/process_attach_pid.in

@@ -1 +0,0 @@
-process attach --pid

lldb/lit/Driver/TestProcessAttach.test

@@ -1,2 +0,0 @@
-# RUN: %lldb -x -b -S %S/Inputs/process_attach_pid.in 2>&1 | FileCheck %s
-# CHECK: requires an argument

lldb/source/Interpreter/Options.cpp

@@ -1362,12 +1362,6 @@ llvm::Expected<Args> Options::Parse(const Args &args,
     int long_options_index = -1;
     val = OptionParser::Parse(argv.size(), &*argv.begin(), sstr.GetString(),
                               long_options, &long_options_index);
-
-    if ((size_t)OptionParser::GetOptionIndex() > argv.size()) {
-      error.SetErrorStringWithFormat("option requires an argument");
-      break;
-    }
-
     if (val == -1)
       break;