From 0c958fba14bbe65cba7a0dbf5b63a2be2ee75213 Mon Sep 17 00:00:00 2001
From: Shoaib Meenai <smeenai@fb.com>
Date: Sat, 30 Dec 2017 08:00:44 +0000
Subject: [PATCH] [ELF] Only scan executables for shlib undefined symbols

If using a version script with a `local: *` in it, symbols in shared
libraries will still get default visibility if another shared library on
the link line has an undefined reference to the symbol. This is quite
surprising. Neither bfd nor gold have this behavior when linking a
shared library, and none of LLD's tests fail without this behavior, so
it seems safe to limit scanShlibUndefined to executables.

As far as executables are concerned, gold doesn't do any automatic
default visibility marking, and bfd issues a link error about a shared
library having a reference to a hidden symbol rather than silently
giving that symbol default visibility. I think bfd's behavior here is
preferable to LLD's, but that's something to be considered in a
follow-up.

Differential Revision: https://reviews.llvm.org/D41524

llvm-svn: 321578
---
 lld/ELF/Driver.cpp                        |  3 ++-
 lld/test/ELF/Inputs/shlib-undefined-ref.s |  4 ++++
 lld/test/ELF/shlib-undefined-shared.s     | 15 +++++++++++++++
 3 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 lld/test/ELF/Inputs/shlib-undefined-ref.s
 create mode 100644 lld/test/ELF/shlib-undefined-shared.s

diff --git a/lld/ELF/Driver.cpp b/lld/ELF/Driver.cpp
index cc76fea2ad5e..b159fe63eb18 100644
--- a/lld/ELF/Driver.cpp
+++ b/lld/ELF/Driver.cpp
@@ -1043,7 +1043,8 @@ template <class ELFT> void LinkerDriver::link(opt::InputArgList &Args) {
     return;
 
   // Handle undefined symbols in DSOs.
-  Symtab->scanShlibUndefined<ELFT>();
+  if (!Config->Shared)
+    Symtab->scanShlibUndefined<ELFT>();
 
   // Handle the -exclude-libs option.
   if (Args.hasArg(OPT_exclude_libs))
diff --git a/lld/test/ELF/Inputs/shlib-undefined-ref.s b/lld/test/ELF/Inputs/shlib-undefined-ref.s
new file mode 100644
index 000000000000..cfb7c60ebc01
--- /dev/null
+++ b/lld/test/ELF/Inputs/shlib-undefined-ref.s
@@ -0,0 +1,4 @@
+.globl f
+f:
+	call	should_not_be_exported@PLT
+	ret
diff --git a/lld/test/ELF/shlib-undefined-shared.s b/lld/test/ELF/shlib-undefined-shared.s
new file mode 100644
index 000000000000..6d60d01bfabe
--- /dev/null
+++ b/lld/test/ELF/shlib-undefined-shared.s
@@ -0,0 +1,15 @@
+# REQUIRES: x86
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-linux-gnu -o %t1.o %S/Inputs/shlib-undefined-ref.s
+# RUN: ld.lld -shared -o %t1.so %t1.o
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-linux-gnu -o %t2.o %s
+# RUN: echo "{ local: *; };" > %t.script
+# RUN: ld.lld -shared -version-script %t.script -o %t2.so %t2.o %t1.so
+# RUN: llvm-nm -g %t2.so | FileCheck -allow-empty %s
+
+# CHECK-NOT: should_not_be_exported
+
+.globl should_not_be_exported
+should_not_be_exported:
+	ret