maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[ASTImporter] Make the Import() return value consistent with the map of imported decls when merging ClassTemplateSpecializationDecls 

When importing a `ClassTemplateSpecializationDecl` definition into a TU with a matching
`ClassTemplateSpecializationDecl` definition and a more recent forward decl, the ASTImporter
currently will call `MapImported()` for the definitions, but will return the forward declaration
from the `ASTImporter::Import()` call.

This is triggering some assertions in LLDB when we try to fully import some DeclContexts
before we delete the 'From' AST. The returned 'To' Decl before this patch is just the most recent
forward decl but that's not the Decl with the definition to which the ASTImporter will import
the child declarations.

This patch just changes that the ASTImporter returns the definition that the imported Decl was
merged with instead of the found forward declaration.

Reviewed By: martong

Differential Revision: https://reviews.llvm.org/D92016
This commit is contained in:
Raphael Isemann 2020-11-24 23:08:57 +01:00
parent a8dc2110cd
commit 0c926e6d24
2 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
clang/lib/AST/ASTImporter.cpp
View File

@ -5423,8 +5423,9 @@ ExpectedDecl ASTNodeImporter::VisitClassTemplateSpecializationDecl(
if (PrevDecl) {
if (IsStructuralMatch(D, PrevDecl)) {
if (D->isThisDeclarationADefinition() && PrevDecl->getDefinition()) {
Importer.MapImported(D, PrevDecl->getDefinition());
CXXRecordDecl *PrevDefinition = PrevDecl->getDefinition();
if (D->isThisDeclarationADefinition() && PrevDefinition) {
Importer.MapImported(D, PrevDefinition);
// Import those default field initializers which have been
// instantiated in the "From" context, but not in the "To" context.
for (auto *FromField : D->fields()) {
@ -5446,7 +5447,7 @@ ExpectedDecl ASTNodeImporter::VisitClassTemplateSpecializationDecl(
//
// Generally, ASTCommon.h/DeclUpdateKind enum gives a very good hint
// what else could be fused during an AST merge.
return PrevDecl;
return PrevDefinition;
}
} else { // ODR violation.
// FIXME HandleNameConflict

19
clang/unittests/AST/ASTImporterTest.cpp
View File

@ -3104,6 +3104,25 @@ TEST_P(ASTImporterOptionSpecificTestBase,
EXPECT_TRUE(ToFun->hasBody());
}
TEST_P(ASTImporterOptionSpecificTestBase, MergeTemplateSpecWithForwardDecl) {
std::string ClassTemplate =
R"(
template<typename T>
struct X { int m; };
template<>
struct X<int> { int m; };
)";
// Append a forward decl for our template specialization.
getToTuDecl(ClassTemplate + "template<> struct X<int>;", Lang_CXX11);
Decl *FromTU = getTuDecl(ClassTemplate, Lang_CXX11);
auto *FromSpec = FirstDeclMatcher<ClassTemplateSpecializationDecl>().match(
FromTU, classTemplateSpecializationDecl(hasName("X"), isDefinition()));
auto *ImportedSpec = Import(FromSpec, Lang_CXX11);
// Check that our definition got merged with the existing definition.
EXPECT_TRUE(FromSpec->isThisDeclarationADefinition());
EXPECT_TRUE(ImportedSpec->isThisDeclarationADefinition());
}
TEST_P(ASTImporterOptionSpecificTestBase,
ODRViolationOfClassTemplateSpecializationsShouldBeReported) {
std::string ClassTemplate =