maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Removed the hack that uses "frame variable" to 

evaluate expressions.  The expression parser and
IR interpreter are now fully capable of evaluating
expressions with as much (or better) fidelity.

<rdar://problem/12879364>

llvm-svn: 172293
This commit is contained in:
Sean Callanan 2013-01-12 02:04:23 +00:00
parent 7cf35ef8f6
commit 0bf0bafbc9
1 changed files with 22 additions and 100 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
lldb/source/Target/Target.cpp
View File

@ -1723,30 +1723,9 @@ Target::EvaluateExpression
ExecutionContext exe_ctx; ExecutionContext exe_ctx;
const size_t expr_cstr_len = ::strlen (expr_cstr);
if (frame) if (frame)
{ {
frame->CalculateExecutionContext(exe_ctx); frame->CalculateExecutionContext(exe_ctx);
Error error;
const uint32_t expr_path_options = StackFrame::eExpressionPathOptionCheckPtrVsMember |
StackFrame::eExpressionPathOptionsNoFragileObjcIvar |
StackFrame::eExpressionPathOptionsNoSyntheticChildren;
lldb::VariableSP var_sp;
// Make sure we don't have any things that we know a variable expression
// won't be able to deal with before calling into it
if (::strcspn (expr_cstr, "()+*&|!~<=/^%,?") == expr_cstr_len)
{
result_valobj_sp = frame->GetValueForVariableExpressionPath (expr_cstr,
options.GetUseDynamic(),
expr_path_options,
var_sp,
error);
// if this expression results in a bitfield, we give up and let the IR handle it
if (result_valobj_sp && result_valobj_sp->IsBitfield())
result_valobj_sp.reset();
}
} }
else if (m_process_sp) else if (m_process_sp)
{ {
@ -1757,62 +1736,6 @@ Target::EvaluateExpression
CalculateExecutionContext(exe_ctx); CalculateExecutionContext(exe_ctx);
} }
if (result_valobj_sp)
{
execution_results = eExecutionCompleted;
// We got a result from the frame variable expression path above...
ConstString persistent_variable_name (m_persistent_variables.GetNextPersistentVariableName());
lldb::ValueObjectSP const_valobj_sp;
// Check in case our value is already a constant value
if (result_valobj_sp->GetIsConstant())
{
const_valobj_sp = result_valobj_sp;
const_valobj_sp->SetName (persistent_variable_name);
}
else
{
if (options.GetUseDynamic() != lldb::eNoDynamicValues)
{
ValueObjectSP dynamic_sp = result_valobj_sp->GetDynamicValue(options.GetUseDynamic());
if (dynamic_sp)
result_valobj_sp = dynamic_sp;
}
const_valobj_sp = result_valobj_sp->CreateConstantValue (persistent_variable_name);
}
lldb::ValueObjectSP live_valobj_sp = result_valobj_sp;
result_valobj_sp = const_valobj_sp;
ClangExpressionVariableSP clang_expr_variable_sp(m_persistent_variables.CreatePersistentVariable(result_valobj_sp));
assert (clang_expr_variable_sp.get());
// Set flags and live data as appropriate
const Value &result_value = live_valobj_sp->GetValue();
switch (result_value.GetValueType())
{
case Value::eValueTypeHostAddress:
case Value::eValueTypeFileAddress:
// we don't do anything with these for now
break;
case Value::eValueTypeScalar:
case Value::eValueTypeVector:
clang_expr_variable_sp->m_flags |= ClangExpressionVariable::EVIsLLDBAllocated;
clang_expr_variable_sp->m_flags |= ClangExpressionVariable::EVNeedsAllocation;
break;
case Value::eValueTypeLoadAddress:
clang_expr_variable_sp->m_live_sp = live_valobj_sp;
clang_expr_variable_sp->m_flags |= ClangExpressionVariable::EVIsProgramReference;
break;
}
}
else
{
// Make sure we aren't just trying to see the value of a persistent // Make sure we aren't just trying to see the value of a persistent
// variable (something like "$0") // variable (something like "$0")
lldb::ClangExpressionVariableSP persistent_var_sp; lldb::ClangExpressionVariableSP persistent_var_sp;
@ -1840,7 +1763,6 @@ Target::EvaluateExpression
options.GetRunOthers(), options.GetRunOthers(),
options.GetTimeoutUsec()); options.GetTimeoutUsec());
} }
}
m_suppress_stop_hooks = old_suppress_value; m_suppress_stop_hooks = old_suppress_value;