maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Un-nest the meat of this function. 

llvm-svn: 124310
This commit is contained in:
John McCall 2011-01-26 19:21:13 +00:00
parent f256eb54a2
commit 0a6bf2ebe2
1 changed files with 58 additions and 59 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

117
clang/lib/CodeGen/CGExpr.cpp
View File

@ -1682,67 +1682,66 @@ LValue CodeGenFunction::EmitCompoundLiteralLValue(const CompoundLiteralExpr *E){
LValue
CodeGenFunction::EmitConditionalOperatorLValue(const ConditionalOperator *E) {
if (E->isGLValue()) {
if (int Cond = ConstantFoldsToSimpleInteger(E->getCond())) {
Expr *Live = Cond == 1 ? E->getLHS() : E->getRHS();
if (Live)
return EmitLValue(Live);
}
llvm::BasicBlock *LHSBlock = createBasicBlock("cond.true");
llvm::BasicBlock *RHSBlock = createBasicBlock("cond.false");
llvm::BasicBlock *ContBlock = createBasicBlock("cond.end");
ConditionalEvaluation eval(*this);
if (E->getLHS())
EmitBranchOnBoolExpr(E->getCond(), LHSBlock, RHSBlock);
else {
Expr *save = E->getSAVE();
assert(save && "VisitConditionalOperator - save is null");
// Intentianlly not doing direct assignment to ConditionalSaveExprs[save]
LValue SaveVal = EmitLValue(save);
ConditionalSaveLValueExprs[save] = SaveVal;
EmitBranchOnBoolExpr(E->getCond(), LHSBlock, RHSBlock);
}
// Any temporaries created here are conditional.
EmitBlock(LHSBlock);
eval.begin(*this);
LValue LHS = EmitLValue(E->getTrueExpr());
eval.end(*this);
if (!LHS.isSimple())
return EmitUnsupportedLValue(E, "conditional operator");
LHSBlock = Builder.GetInsertBlock();
Builder.CreateBr(ContBlock);
// Any temporaries created here are conditional.
EmitBlock(RHSBlock);
eval.begin(*this);
LValue RHS = EmitLValue(E->getRHS());
eval.end(*this);
if (!RHS.isSimple())
return EmitUnsupportedLValue(E, "conditional operator");
RHSBlock = Builder.GetInsertBlock();
EmitBlock(ContBlock);
llvm::PHINode *phi = Builder.CreatePHI(LHS.getAddress()->getType(),
"cond-lvalue");
phi->reserveOperandSpace(2);
phi->addIncoming(LHS.getAddress(), LHSBlock);
phi->addIncoming(RHS.getAddress(), RHSBlock);
return MakeAddrLValue(phi, E->getType());
if (!E->isGLValue()) {
// ?: here should be an aggregate.
assert((hasAggregateLLVMType(E->getType()) &&
!E->getType()->isAnyComplexType()) &&
"Unexpected conditional operator!");
return EmitAggExprToLValue(E);
}
// ?: here should be an aggregate.
assert((hasAggregateLLVMType(E->getType()) &&
!E->getType()->isAnyComplexType()) &&
"Unexpected conditional operator!");
return EmitAggExprToLValue(E);
if (int Cond = ConstantFoldsToSimpleInteger(E->getCond())) {
Expr *Live = Cond == 1 ? E->getLHS() : E->getRHS();
if (Live)
return EmitLValue(Live);
}
llvm::BasicBlock *LHSBlock = createBasicBlock("cond.true");
llvm::BasicBlock *RHSBlock = createBasicBlock("cond.false");
llvm::BasicBlock *ContBlock = createBasicBlock("cond.end");
ConditionalEvaluation eval(*this);
if (E->getLHS())
EmitBranchOnBoolExpr(E->getCond(), LHSBlock, RHSBlock);
else {
Expr *save = E->getSAVE();
assert(save && "VisitConditionalOperator - save is null");
// Intentianlly not doing direct assignment to ConditionalSaveExprs[save]
LValue SaveVal = EmitLValue(save);
ConditionalSaveLValueExprs[save] = SaveVal;
EmitBranchOnBoolExpr(E->getCond(), LHSBlock, RHSBlock);
}
// Any temporaries created here are conditional.
EmitBlock(LHSBlock);
eval.begin(*this);
LValue LHS = EmitLValue(E->getTrueExpr());
eval.end(*this);
if (!LHS.isSimple())
return EmitUnsupportedLValue(E, "conditional operator");
LHSBlock = Builder.GetInsertBlock();
Builder.CreateBr(ContBlock);
// Any temporaries created here are conditional.
EmitBlock(RHSBlock);
eval.begin(*this);
LValue RHS = EmitLValue(E->getRHS());
eval.end(*this);
if (!RHS.isSimple())
return EmitUnsupportedLValue(E, "conditional operator");
RHSBlock = Builder.GetInsertBlock();
EmitBlock(ContBlock);
llvm::PHINode *phi = Builder.CreatePHI(LHS.getAddress()->getType(),
"cond-lvalue");
phi->reserveOperandSpace(2);
phi->addIncoming(LHS.getAddress(), LHSBlock);
phi->addIncoming(RHS.getAddress(), RHSBlock);
return MakeAddrLValue(phi, E->getType());
}
/// EmitCastLValue - Casts are never lvalues unless that cast is a dynamic_cast.